Lithostitched

Lithostitched

21M Downloads

[Compatibility] My mod's village houses (which are added conditionally to pools) are not working with Lithostitched installed

filloax opened this issue ยท 7 comments

commented

Hi, I'm a developer for Ruins of Growsseth. This mod adds village houses with a config option to disable them, and to make that work adds them to the village pools on server started (code here, see `addBuildingToPool'.

I noticed when testing to solve a crash on my side with Improved Villages that even after solving that, village houses from my mod are not getting properly added to villages. I have tested that with a command added by my mod to find specific jigsaw parts (glocate jigsawStructure), so it is possible the error might be there, even if I tested via debug and the checks in the command seem to be working correctly.

Is this normal with how the library works? If so, is there a way to do this in the way intended by the library to be compatible?

commented

I believe the issue is in this line.

The village buildings in your mod get added once the server has fully started, but Lithostitched compiles template pools into an optimized format between the server starting and server started events on both modloaders. Try moving that line up into the onServerStarting method.

commented

What Lithostitched version are you seeing this issue in? I believe I resolved this issue in 1.4.

commented

This was with lithostitched-neoforge-1.21.1-1.4.2 placed in the run/mods folder

commented

I was able to replicate the issue on latest, looking into it.

commented

Thanks, let me know if I have to do anything for compat

commented

Just moving it there doesn't seem to work

commented

Other dev here. Moving it there was the solution, but we also had to use Lithostitched's method for adding the buildings to the pools (if loaded).
Leaving the commit here for reference.