Issue on Version for 1.21.1 (1.4.5)
suerion opened this issue · 7 comments
Had build it from Source, the files have an issue, it work with the builded one
!!! There is some issue on Modrinth and Curseforge. Please Check it again
Just downloaded the "1.4.5" (MC 1.21.1 Fabric) .jar file from Modrinth a few minutes ago (20 Apr 2025) - the fabric.mod.json file within has the following contents (abbreviated):
{
"schemaVersion": 1,
"id": "lithostitched",
"version": "1.4.2",
"name": "Lithostitched",
# ...
}Note the version item.
Looking at the build code it looks like the version data published in fabric.mod.json file is pulled from the global build configuration in gradle.properties ("1.4.5" if I'm reading everything correctly - I'm a developer but not a MC modder).
This does suggest that the file on Modrinth is in fact 1.4.2.
I also downloaded the 1.4.4 release, and it also identifies itself as "1.4.2".
As a developer my first thought is that the build process is for some reason not clearing out "old" files before it compiles/builds the new version, and so those old files are ending up in the final .jar files.
I hope this helps?
A follow-up to my previous comment - I was looking at 1.4.5 for MC 1.21.4 Fabric (filename lithostitched-fabric-1.21.4-1.4.5.jar, from Modrinth), and its fabric.mod.json shows a version of "1.4.4". So I think this is broader build issue.
I respectfully suggest that all current Lithostitched releases need to be re-built and re-released (as a clean "1.5.0" perhaps), otherwise bug reporting/fixing becomes much more difficult when we don't know which actual releases are involved; a big headache when other mods are involved with a report. These "problem" releases should probably get removed/deprecated on Modrinth/Curseforge for the same reason.
Note that the new 1.4.7 release for 1.21.1 (Fabric) is still reporting itself as "1.4.2"; the fabric.mod.json file in the .jar lists the version as "1.4.2"
(Add) I just checked the 1.21.5 file, and it does correctly report a version of "1.4.7".
Did some digging, there's a weird issue with my code setup where the mod compiles old metadata files instead of updated ones.
I cleared the caches to fix this in (neo)forge 1.4.8. I wasn't aware this was also an issue on Fabric until I reread this issue, so a 1.4.9 hotfix will soon address that.
I will leave the issue open until I properly fix it on my end.
Did some digging, there's a weird issue with my code setup where the mod compiles old metadata files instead of updated ones.
I cleared the caches to fix this in (neo)forge 1.4.8. I wasn't aware this was also an issue on Fabric until I reread this issue, so a 1.4.9 hotfix will soon address that.
I will leave the issue open until I properly fix it on my end.
HEy, thanks a lot :) yeah hope so, had last time also on Intellij latest cache issue, and some weird settings on git, that intellij has uploaded the cache within...
Thanks for your work :)
