Waystones from Wraith Waystones generate without a count cap (1.3.5+)
JacobTDC opened this issue ยท 8 comments
Lithostitched version 1.4+ seem to ignore limits on structures injected into pools. This is noticeable when installing Lithostitched ^1.4, CTOV ^3.4.11, and Wraith Waystones 3.3.2 on Minecraft 1.20.1 Fabric.
Installing the aforementioned mods, creating a superflat world, and running /place structure [CTOV medium taiga village id] seems to reproduce the issue consistently, where many waystones will generate, even though the config is set to only one per village. The issue does not occur in Lithostitched versions prior to 1.4.
This appears to be an issue with Lithostitched, and not the other mods, but I'm not entirely certain.
I have a similar issue. CTOV villages generate with many houses for mods not in the pack. Seems the predicates are broken. 1.20.1 Forge.
Successfully replicated. Strangely, though, it doesn't appear to be an issue with all injection limits; I was able to add a guaranteed element to vanilla villages without any issues.
Issue has been identified.
Wraith Waystones does its own injection into template pools, and this applies to CTOV as well as can be seen in the logs.
[Server thread/INFO]: Adding waystone fwaystones:village_waystone to village minecraft:village/snowy/houses
[Server thread/INFO]: Adding waystone fwaystones:village_waystone to village ctov:village/plains/house
They have some code inside of vanilla's jigsaw structure generator to apply limits based on the config file. However, Lithostitched completely bypasses vanilla jigsaw code so all jigsaw structures can support guaranteed pool elements and generate faster.
This is a bit tricky to fix. Lithostitched's jigsaw code has diverged from vanilla's far enough that I can't just replace the bypass of vanilla jigsaw code. I will reach out to this dev and hopefully get some sort of compat patch built into Wraith Waystones.
PR to fix this issue has been passed onto Fabric Waystones here.
Fixed by merge LordDeatHunter/FabricWaystones#277.
There is a newish issue now; Wraith Waystones is generating exactly one more waystone per village than it should now, instead of several. I've opened a new issue at LordDeatHunter/FabricWaystones/issues/280.