Compatibility with Yet Another Bingo
fennifith opened this issue · 1 comments
Hi! I'm doing something pretty cursed in my mod, and it seems like it breaks stuff with lithostitched & "Underground Rivers". I'm not sure if this can be fixed on my side, though - wanted to open this for advice and if ask this can be solved in lithostitched or if there's a way to solve it on my end :)
Can be minimally reproduced on 1.21.1 with:
- Install fabric api, lithostitched, underground rivers, and yet another bingo
- Press the "Bingo" button on the title screen
- Start a game, then run
/bingo endand press "Return to Lobby" - Start another game, and something like this happens:
Logs: https://mclo.gs/XPkb2Lt
To explain, ServerWorldImpl.kt (called from ResetService.kt) changes the world seed and recreates worlds on the same running server instance by closing all worlds and then invoking MinecraftServer:loadWorld again. Surprisingly, this is the first time anyone's reported it causing an actual issue. I'm guessing some reference is kept to the previous world that breaks worldgen on the new one.
The alternative is just directing players to manually recreate the world, which I'm happy to do if this turns out to be a pain.
(I'm also fennifith on discord if it's easier to DM about this)
Thanks!
