BetterPortals compatibility
Johni0702 opened this issue · 4 comments
It appears like both BP and LT replace MC's ChunkRenderDispatcher.
BP basically re-implements the ChunkRenderDispatcher (here) to allow it to be shared by multiple RenderGlobal instances (i.e. multiple worlds).
LT, afaict, seems to only overwrite a single method (uploadChunk) to add its tiles into the vertex buffer.
Is there some other reason which I'm missing?
If there isn't, then I'd suggest changing LT to merely inject into the uploadChunk method of the original ChunkRenderDispatcher instead of fully replacing it.
BP also eventually delegates the chunks it has handled to that method, so any of LT's additions to it would be functional with BP as long as they aren't assuming there to only be one world.
Nice to hear that! Thanks for your help. I will release the new version this week.
That's the best idea indeed. I changed it, can you try out whether it works now?
https://www.dropbox.com/s/6g3mqe7r7omvmy6/CreativeCore_v1.9.63_mc1.12.2.jar?dl=1
https://www.dropbox.com/s/gzaenymi8mg584d/LittleTiles_v1.5.0-pre159_mc1.12.2.jar?dl=1