Server Enchantment Trades crash the game when a certain mod is loaded.

Question

Server Enchantment Trades crash the game when a certain mod is loaded.

TheButterbrotMan opened this issue 3 years ago · 79 comments

TheButterbrotMan commented 3 years ago

https://bytebin.lucko.me/OnrPZoYrvc

TheButterbrotMan commented 3 years ago

Ok. Lol.

0xJoeMama · Answer 1 · 2022-03-29T19:06:20.000Z

I am convinced there is a mod in your pack that is providing invalid max level values for enchantments. This time I am going to look into it, in depth, because that is behavior most mods consider invalid. Some research needs to happen. Could you try to reduce your pack to all mods that add enchantments and send a list of those mods here. If you could, I would really appreciate it.

Thank you for reporting! I am looking into this personally.

TheButterbrotMan · Answer 2 · 2022-03-29T19:08:30.000Z

I will try. I also link my modpack here
Deathdusk (Client)-DEV.zip
.

TheButterbrotMan · Answer 3 · 2022-03-29T19:09:07.000Z

Is there any specific enchantment mod where i should begin? Some kind of enchantment or generally enchantment mods?

TheButterbrotMan · Answer 4 · 2022-03-29T19:10:23.000Z

Also could the enchantment be allready included here?

Entity NBT: {AbsorptionAmount:0.0f,Age:0,Air:300s,ArmorDropChances:[0.085f,0.085f,0.085f,0.085f],ArmorItems:[{},{},{},{}],Attributes:[{Base:0.5d,Name:"minecraft:generic.movement_speed"},{Base:48.0d,Modifiers:[{Amount:-0.04102265703986181d,Name:"Random spawn bonus",Operation:1,UUID:[I;-193497916,1551451467,-1660894393,-2024918408]}],Name:"minecraft:generic.follow_range"},{Base:0.0d,Name:"stepheightentityattribute:stepheight"}],BMLootBlock:0b,BalmData:{},Brain:{memories:{}},CanPickUpLoot:0b,DeathTime:0s,FallDistance:0.0f,FallFlying:0b,Fire:-1s,ForcedAge:0,HandDropChances:[0.085f,0.085f],HandItems:[{},{}],Health:20.0f,HurtByTimestamp:0,HurtTime:0s,Inventory:[],Invulnerable:0b,IsCrimson:0b,LeftHanded:0b,Motion:[0.0d,-0.0784000015258789d,0.0d],Offers:{Recipes:[{Reputation:0,buy:{Count:1b,id:"llamarama:flight_of_the_bumble_llama"},buyB:{Count:1b,id:"minecraft:air"},demand:0,id:"minecraft:trade_offer",maxUses:4,priceMultiplier:1.0f,rewardExp:1b,sell:{Count:1b,id:"llamarama:llamajama_disc"},specialPrice:0,uses:0,xp:3},{Reputation:0,buy:{Count:24b,id:"minecraft:paper"},buyB:{Count:1b,id:"minecraft:air"},demand:0,id:"minecraft:trade_offer",maxUses:12,priceMultiplier:1.0f,rewardExp:1b,sell:{Count:1b,id:"minecraft:emerald"},specialPrice:0,uses:0,xp:2},{Reputation:0,buy:{Count:6b,id:"minecraft:emerald"},buyB:{Count:1b,id:"minecraft:air"},demand:0,id:"minecraft:trade_offer",maxUses:8,priceMultiplier:1.0f,rewardExp:1b,sell:{Count:6b,id:"llamarama:raw_llama_meat"},specialPrice:0,uses:0,xp:3}]},OnGround:1b,PersistenceRequired:0b,PortalCooldown:0,Pos:[-79.5d,65.0d,-152.5d],Rotation:[89.20901f,-9.18134f],Tags:["collective-fabric.checked"],UUID:[I;-1971168943,-433306139,-2095539852,2073394574],arcanus:{DiscombobulatedTimer:0,IsDiscombobulated:0b},bm_IsStunted:0b,cardinal_components:{"bewitchment:additional_water_data":{Submerged:0b,WetTimer:0},"bewitchment:blood":{Blood:100},"bewitchment:curses":{Curses:[]},"bewitchment:fake_mob":{TargetUUID:""},"bewitchment:familiar":{Familiar:0b},"bewitchment:minion":{MasterUUID:""},"eldritch_mobs:eldritch_modifiers":{eldritch:0b,elite:0b,rank:0b,saved_mods:{},ultra:0b},"immortuoscalyx:infection":{infectionFollower:0b,infectionImpedement:0b,infectionProgression:0,infectionResistance:1.0d,infectionTimer:0},"pickyourpoison:numbnessdamage":{DamageAccumulated:0.0f},"the_aether:condition_manager":{"the_aether:venom":{chronic:0.0f,temporary:0.0f}}},checkedIfInLampChunk:0b,cpaCooldown:0,cpadidTP:0b}

0xJoeMama · Answer 5 · 2022-03-29T19:12:50.000Z

Is there any specific enchantment mod where i should begin? Some kind of enchantment or generally enchantment mods?

Not really. It can be any mod adding enchantments, since no specific info is provided on the log.

Also could the enchantment be allready included here?

That is actually all the data that was able to save. It wouldn't be there, since the issue came when encoding the extra NBT data on the entity.

TheButterbrotMan · Answer 6 · 2022-03-29T19:15:06.000Z

Thats all. LOL. Very less mods out of 400 that adds enchantments.

Whats now?

0xJoeMama · Answer 7 · 2022-03-29T19:20:25.000Z

Reposting because I am checking them one by one:

0xJoeMama · Answer 8 · 2022-03-29T19:23:16.000Z

Ladies and gentlemen, we got it!

https://github.com/codeman1o1/Therrassium/blob/main/src/main/java/me/codeman1o1/therrassium/enchantments/Infected.java

TheButterbrotMan · Answer 9 · 2022-03-29T19:23:38.000Z

Are you able to tell me for what you did search in Github? Im guessing you did a search for a specific string on each mods git?

0xJoeMama · Answer 10 · 2022-03-29T19:25:08.000Z

Are you able to tell me for what you did search in Github?

Well simply put, I went to the curseforge page of the mods. Found their gh. Went there. Went through and found all classes that implement Enchantment and just looked for sus things like changable or default max levels.

0xJoeMama · Answer 11 · 2022-03-29T19:25:56.000Z

However I need to check what the default value for max level is so give me a sec.

0xJoeMama · Answer 12 · 2022-03-29T19:27:47.000Z

Hm, the value defaults to 1 actually. I may have to look through again. However that one is the only red flag I found.

0xJoeMama · Answer 13 · 2022-03-29T19:28:59.000Z

So. Let's try this. I'll send you a mod that will detect invalid enchantment levels. Run the pack with it and send the log. Does that sound like a deal?

TheButterbrotMan · Answer 14 · 2022-03-29T19:30:07.000Z

Yes. - Deal!

TheButterbrotMan · Answer 15 · 2022-03-29T19:49:47.000Z

Yes, currently testing!

0xJoeMama · Answer 16 · 2022-03-29T19:47:58.000Z

There you go sir! https://www.dropbox.com/s/ngtnprml2lj9axn/InvalidEnchantDetector-1.0-SNAPSHOT.jar?dl=0

0xJoeMama · Answer 17 · 2022-03-29T19:48:13.000Z

does this link work?

TheButterbrotMan · Answer 18 · 2022-03-29T19:50:31.000Z

latest.log? Do i need to create a world? Or just start to menu and close?

TheButterbrotMan · Answer 19 · 2022-03-29T19:51:14.000Z

Incompatible mod set!
net.fabricmc.loader.impl.FormattedException: net.fabricmc.loader.impl.discovery.ModResolutionException: Mod discovery failed!
	at net.fabricmc.loader.impl.FabricLoaderImpl.load(FabricLoaderImpl.java:192)
	at net.fabricmc.loader.impl.launch.knot.Knot.init(Knot.java:142)
	at net.fabricmc.loader.impl.launch.knot.Knot.launch(Knot.java:71)
	at net.fabricmc.loader.impl.launch.knot.KnotClient.main(KnotClient.java:23)
Caused by: net.fabricmc.loader.impl.discovery.ModResolutionException: Mod discovery failed!
	at net.fabricmc.loader.impl.discovery.ModDiscoverer.lambda$discoverMods$1(ModDiscoverer.java:137)
	at net.fabricmc.loader.impl.util.ExceptionUtil.gatherExceptions(ExceptionUtil.java:33)
	at net.fabricmc.loader.impl.discovery.ModDiscoverer.discoverMods(ModDiscoverer.java:137)
	at net.fabricmc.loader.impl.FabricLoaderImpl.setup(FabricLoaderImpl.java:208)
	at net.fabricmc.loader.impl.FabricLoaderImpl.load(FabricLoaderImpl.java:187)
	... 3 more
Caused by: net.fabricmc.loader.impl.metadata.ParseMetadataException: Error reading fabric.mod.json file for mod at C:\Users\elias\curseforge\minecraft\Instances\Deathdusk\mods\InvalidEnchantDetector-1.0-SNAPSHOT.jar: Invalid mod id InvalidEnchantDetector:
	- It starts with an invalid character 'I' (it must be a lowercase a-z - uppercase isn't allowed anywhere in the ID)
	- It contains invalid characters: 'D', 'E'!
	at net.fabricmc.loader.impl.metadata.ModMetadataParser.checkModId(ModMetadataParser.java:233)
	at net.fabricmc.loader.impl.metadata.ModMetadataParser.parseMetadata(ModMetadataParser.java:54)
	at net.fabricmc.loader.impl.discovery.ModDiscoverer$ModScanTask.computeJarFile(ModDiscoverer.java:269)
	at net.fabricmc.loader.impl.discovery.ModDiscoverer$ModScanTask.compute(ModDiscoverer.java:232)
	at net.fabricmc.loader.impl.discovery.ModDiscoverer$ModScanTask.compute(ModDiscoverer.java:194)
	at java.base/java.util.concurrent.RecursiveTask.exec(RecursiveTask.java:100)
	at java.base/java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:373)
	at java.base/java.util.concurrent.ForkJoinPool$WorkQueue.topLevelExec(ForkJoinPool.java:1182)
	at java.base/java.util.concurrent.ForkJoinPool.scan(ForkJoinPool.java:1655)
	at java.base/java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1622)
	at java.base/java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:165)

FIX YOUR MOD!! Lol.

0xJoeMama · Answer 20 · 2022-03-29T19:54:24.000Z

oop
my bad
for some reason intellij picks up the id from the name of the project lol

0xJoeMama · Answer 21 · 2022-03-29T19:55:58.000Z

How about this one? https://www.dropbox.com/s/d9oh5sa9cwo4da0/InvalidEnchantDetector-1.0-SNAPSHOT.jar?dl=0

0xJoeMama · Answer 22 · 2022-03-29T19:56:19.000Z

latest.log? Do i need to create a world? Or just start to menu and close?

Just start the game lol

TheButterbrotMan · Answer 23 · 2022-03-29T19:57:12.000Z

How about this one? https://www.dropbox.com/s/d9oh5sa9cwo4da0/InvalidEnchantDetector-1.0-SNAPSHOT.jar?dl=0

Cant download. Its deleted. Lol.

0xJoeMama · Answer 24 · 2022-03-29T19:57:21.000Z

Its deleted lol

You clicked at the wrong moment lol

0xJoeMama · Answer 25 · 2022-03-29T19:57:53.000Z

How about this one? https://www.dropbox.com/s/d9oh5sa9cwo4da0/InvalidEnchantDetector-1.0-SNAPSHOT.jar?dl=0

Cant download. Its deleted. Lol.

I changed the link man chill

TheButterbrotMan · Answer 26 · 2022-03-29T19:57:54.000Z

Ok. Starting now.

TheButterbrotMan · Answer 27 · 2022-03-29T20:03:57.000Z

Nah, was loaded since five minutes, but was getting food, at the door, from the pizzaman. Lol.

TheButterbrotMan · Answer 28 · 2022-03-29T20:04:20.000Z

On 1.18.1 i was at 650. Lol.

0xJoeMama · Answer 29 · 2022-03-29T20:02:57.000Z

Still loading ig

0xJoeMama · Answer 30 · 2022-03-29T20:03:14.000Z

I mean dang 400 mods is a lot even for fabric standards lol

TheButterbrotMan · Answer 31 · 2022-03-29T20:03:27.000Z

https://bytebin.lucko.me/PEfBgTrCIE

0xJoeMama · Answer 32 · 2022-03-29T20:06:02.000Z

uhm
You didn't put the mod in the pack lol

0xJoeMama · Answer 33 · 2022-03-29T20:07:39.000Z

Or I got an older log

TheButterbrotMan · Answer 34 · 2022-03-29T20:08:26.000Z

Ehm. The mod is in. Its the actual log. I try again.

0xJoeMama · Answer 35 · 2022-03-29T20:09:35.000Z

I mean if you check the modid list, enchant-detect isn't present lol

TheButterbrotMan · Answer 36 · 2022-03-29T20:11:08.000Z

Yea, i try again. Maybe i did something wrong. Lol.

0xJoeMama · Answer 37 · 2022-03-29T20:11:17.000Z

Okay listen. I know what you are gonna say, but I made typo in the old code and the check it did was actually the opposite of what I wanted.

0xJoeMama · Answer 38 · 2022-03-29T20:11:25.000Z

Wait for a new version

0xJoeMama · Answer 39 · 2022-03-29T20:11:56.000Z

https://www.dropbox.com/s/ixm8eze926783g6/InvalidEnchantDetector-1.0-SNAPSHOT.jar?dl=0

0xJoeMama · Answer 40 · 2022-03-29T20:12:02.000Z

This should work

0xJoeMama · Answer 41 · 2022-03-29T20:12:57.000Z

I tested this one lol

0xJoeMama · Answer 42 · 2022-03-29T20:19:12.000Z

Could you go quicker please? It's really late here and I need to go to sleep.

TheButterbrotMan · Answer 43 · 2022-03-29T20:14:49.000Z

https://bytebin.lucko.me/vp2DGJqS6m <- 2nd Version

https://bytebin.lucko.me/LTflM1fWzK <- 3nd Version

0xJoeMama · Answer 44 · 2022-03-29T20:16:48.000Z

https://bytebin.lucko.me/vp2DGJqS6m <- 2nd Version

Well the mod is present here. But its not the working version :(

TheButterbrotMan · Answer 45 · 2022-03-29T20:20:28.000Z

https://bytebin.lucko.me/vp2DGJqS6m <- 2nd Version

https://bytebin.lucko.me/LTflM1fWzK <- 3nd Version

Could you go quicker please? It's really late here and I need to go to sleep.

Im doing my bestest and fastest!

TheButterbrotMan · Answer 46 · 2022-03-29T20:21:20.000Z

Reference map 'InvalidEnchantDetector-refmap.json' for enchant-detector.mixin.json could not be read. If this is a development environment you can ignore this message is this bad?

0xJoeMama · Answer 47 · 2022-03-29T20:21:56.000Z

dw about that one

0xJoeMama · Answer 48 · 2022-03-29T20:22:08.000Z

https://bytebin.lucko.me/vp2DGJqS6m <- 2nd Version
https://bytebin.lucko.me/LTflM1fWzK <- 3nd Version

Could you go quicker please? It's really late here and I need to go to sleep.

Im doing my bestest and fastest!

thank you

0xJoeMama · Answer 49 · 2022-03-29T20:26:31.000Z

I am afraid I will have to go. We shall continue tomorrow.

TheButterbrotMan · Answer 50 · 2022-03-29T20:27:44.000Z

https://bytebin.lucko.me/WGX3Z4Dttp

Ok :( Have a good night.

0xJoeMama · Answer 51 · 2022-03-30T04:26:55.000Z

https://www.dropbox.com/s/ixm8eze926783g6/InvalidEnchantDetector-1.0-SNAPSHOT.jar?dl=0

@0xJoeMama could you share/elaborate what that helper mod does? Because I look at huge ass logs and don't know what's going on haha

Just prints any enchantment with a max level less than or equal to one lol

0xmycf · Answer 52 · 2022-03-29T22:59:47.000Z

https://www.dropbox.com/s/ixm8eze926783g6/InvalidEnchantDetector-1.0-SNAPSHOT.jar?dl=0

@0xJoeMama could you share/elaborate what that helper mod does? Because I look at huge ass logs and don't know what's going on haha

0xmycf · Answer 53 · 2022-03-29T23:14:34.000Z

Maybe we should just change this random.nextInt(Math.max(0, it.getMaxLevel())) + 1)) to random.nextInt(Math.max(1, it.getMaxLevel())) + 1)), since random.nextInt(0) fails too.

0xmycf · Answer 54 · 2022-03-30T13:41:53.000Z

@TheButterbrotMan your logs show your computer user name. I don't know if you want that.

TheButterbrotMan · Answer 55 · 2022-03-30T13:45:51.000Z

@TheButterbrotMan your logs show your computer user name. I don't know if you want that.

Yea, I know. But it is no matter for me. But thank you.

0xmycf · Answer 56 · 2022-03-30T13:49:45.000Z

I reviewed the files you send, there is no indication of an enchantment that has a non-positive (-inf,0] max value.

Maybe @0xJoeMama|s mod is missing some, but I would assume his mod hooks in at the correct time.

Did you check the llama mod with only one of the others to find out with what mod that happened?

Edit: Maybe I missed it, but did you make this pack yourself or is this a pack you can download somewhere?

0xJoeMama · Answer 57 · 2022-03-30T17:02:08.000Z

In reality, that should never happen.

TheButterbrotMan · Answer 58 · 2022-03-30T14:58:06.000Z

Im a modpack author, so you can download it but yes, it's also mine. Lol. Do you want the .zip?

Haven't checked it with only enchantments mods, because I don't really know how to reproduce.

Maybe it's hook to early, change it maybe to doing at after everything is loaded. If possible.

0xJoeMama · Answer 59 · 2022-03-30T17:01:44.000Z

Maybe we should just change this random.nextInt(Math.max(0, it.getMaxLevel())) + 1)) to random.nextInt(Math.max(1, it.getMaxLevel())) + 1)), since random.nextInt(0) fails too.

I am aware that this is the fix. However we still need to figure out what the mod causing this issue is, since max returning 0 means some mod is either giving 0 or <0 for the max level.

0xJoeMama · Answer 60 · 2022-03-30T16:59:23.000Z

Hello again! I have changed the mod because I realised that my 11 pm self doesn't realise mods don't get loaded at the same time. Try this version of the mod: https://www.dropbox.com/s/kfoqllcwcwa8bp8/InvalidEnchantDetector-1.0-SNAPSHOT.jar?dl=0

0xJoeMama · Answer 61 · 2022-03-30T17:00:02.000Z

Maybe it's hook to early, change it maybe to doing at after everything is loaded. If possible.

That was literally the issue. 11pm me doesn't function lol

0xmycf · Answer 62 · 2022-03-30T19:13:47.000Z

In reality, that should never happen.

Yes I agree.

TheButterbrotMan · Answer 63 · 2022-03-30T19:26:09.000Z

Hello again! I have changed the mod because I realised that my 11 pm self doesn't realise mods don't get loaded at the same time. Try this version of the mod: https://www.dropbox.com/s/kfoqllcwcwa8bp8/InvalidEnchantDetector-1.0-SNAPSHOT.jar?dl=0

Ill do.

TheButterbrotMan · Answer 64 · 2022-03-30T19:37:54.000Z

Another one!

https://bytebin.lucko.me/CPMEP1x563

0xmycf · Answer 65 · 2022-03-30T19:38:18.000Z

Thank you. I’ll look through it in a bit!

0xmycf · Answer 66 · 2022-03-30T19:57:19.000Z

It's not logging anything.

@0xJoeMama could you share the helper mod with me so I can make adjustments too?

0xJoeMama · Answer 67 · 2022-03-30T20:01:58.000Z

It's not logging anything.

@0xJoeMama could you share the helper mod with me so I can make adjustments too?

You need to join a world

TheButterbrotMan · Answer 68 · 2022-03-30T20:07:36.000Z

Ok sir

22:17 - Still generating.

TheButterbrotMan · Answer 69 · 2022-03-30T20:25:06.000Z

https://bytebin.lucko.me/bo9vPWAos8

0xmycf · Answer 70 · 2022-03-30T20:31:46.000Z

Huh, I looked through it twice. They are all non-negative -- meaning [0,inf). Maybe I am missing something and the nextInt gets called on a 0 value somewhere...?

TheButterbrotMan · Answer 71 · 2022-03-31T07:35:20.000Z

Huh, I looked through it twice. They are all non-negative -- meaning [0,inf). Maybe I am missing something and the nextInt gets called on a 0 value somewhere...?

What are you talking about vanillatweaks posts like 20 enchantments with 0 as their max level lol.

So... VanillaTweaks is the cause?

0xJoeMama · Answer 72 · 2022-03-31T04:57:18.000Z

Huh, I looked through it twice. They are all non-negative -- meaning [0,inf). Maybe I am missing something and the nextInt gets called on a 0 value somewhere...?

What are you talking about vanillatweaks posts like 20 enchantments with 0 as their max level lol.

0xJoeMama · Answer 73 · 2022-03-31T04:57:52.000Z

Huh, I looked through it twice. They are all non-negative -- meaning [0,inf). Maybe I am missing something and the nextInt gets called on a 0 value somewhere...?

Also you need a positive bound for nextInt not 0

0xmycf · Answer 74 · 2022-03-31T11:55:16.000Z

Maybe we should just change this random.nextInt(Math.max(0, it.getMaxLevel())) + 1)) to random.nextInt(Math.max(1, it.getMaxLevel())) + 1)), since random.nextInt(0) fails too.

I just saw that we add the 1 after the max is calculated. My bad.

0xJoeMama · Answer 75 · 2022-03-31T11:52:42.000Z

Huh, I looked through it twice. They are all non-negative -- meaning [0,inf). Maybe I am missing something and the nextInt gets called on a 0 value somewhere...?

What are you talking about vanillatweaks posts like 20 enchantments with 0 as their max level lol.

So... VanillaTweaks is the cause?

Yes. I will have to research whether we need to modify our balues or not and/or make an issue in vanillatweaks

0xJoeMama · Answer 76 · 2022-03-31T11:51:25.000Z

Yes but even if this IS chosen we add 1 to the max bound and it gets 1 again, and 1 > 0. I don’t see how this would crash the game.

The crash is because we are using 0 as a max bound

0xmycf · Answer 77 · 2022-03-31T09:22:20.000Z

Yes but even if this IS chosen we add 1 to the max bound and it gets 1 again, and 1 > 0. I don’t see how this would crash the game.

0xJoeMama · Answer 78 · 2022-03-31T12:01:05.000Z

I just saw that we add the 1 after the max is calculated. My bad.

Well your change still works but we should notify vanillatweaks. This behavior is kind of unsuspected by most mods unless setting the max level to 0 is a common practice.

Share to