LLibrary

LLibrary

67M Downloads

Implement a fast and descriptive fail when RuntimePatcher has not been transformed

JamiesWhiteShirt opened this issue ยท 0 comments

commented

In the event that a RuntimePatcher has for some reason not been transformed it starts loading classes it should never load, resulting in nondescriptive ClassCircularityErrors. I have seen several people install the 1.11.2 version of Literal Ascension and the 1.11 version of LLibrary in Minecraft 1.11.2 resulting in a lot of confusion.

I propose that something should be done to add a fast and descriptive fail when a RuntimePatcher has not been transformed. There are several ways to go about doing this. Ideally it should be compatible with existing RuntimePatchers.

My proposal is to inject some information into the transformed RuntimePatcher classes that indicates that the RuntimePatcher is transformed, perhaps with an annotation . Make the RuntimePatcher constructor throw a RuntimeException if the class does not have the annotation.