Logistics Pipes

Logistics Pipes

Mods
13M Downloads

[Bug] Pipe's NBT don't save properly

KorewaLidesu opened this issue ยท 4 comments

commented

writetoNBT doesn't fire after pause/leave the world unless you update the tile entity manual or tick() kick in.
How to reproduct:
Join the world, change stuff on pipe then leave immediately
Join again and see result.
Environment: Dev branch, no changed in core.
Video: https://www.youtube.com/watch?v=Q7wQEYYXkEQ

commented

May related to #995

commented

I just found out reason why.
Pipe didn't markDirty when close gui cause their NBT don't sync properly.

commented

Crafting pipe, provider pipe, supplier pipe and basic logistics pipe should be fixed since now in ffe178d

So let's make a list with TEs missing properties and therefore do not save correctly after modification:

  • PipeBlockRequestTable (technically a pipe)
  • PipeFluidExtractor (no GUI)
  • PipeFluidInsertion (no GUI)
  • PipeFluidSatellite
  • PipeFluidSupplierMk2
  • PipeItemsFirewall
  • PipeItemsFluidSupplier
  • PipeItemsInvSysConnector
  • PipeItemsRequestLogisticsMk2
  • PipeItemsSatelliteLogistics
  • PipeItemsSystemDestinationLogistics
  • PipeItemsSystemEntranceLogistics
  • PipeLogisticsChassis (pointedAdjacent and slotUpgradeManagers)
commented

All tick'd is mean it is implemented
And all in here hasn't test properly, so I will as someone to check it first before the PR

  • PipeBlockRequestTable
  • PipeFluidExtractor
  • PipeFluidInsertion
  • PipeFluidSatellite
  • PipeFluidSupplierMk2
  • PipeItemsFirewall
  • PipeItemsFluidSupplier
  • PipeItemsInvSysConnector
  • PipeItemsRequestLogisticsMk2
  • PipeItemsSatelliteLogistics
  • PipeItemsSystemDestinationLogistics
  • PipeItemsSystemEntranceLogistics
  • PipeLogisticsChassis