Minetweaker cannot resolve Logistics Pipes blocks.

Question

Minetweaker cannot resolve Logistics Pipes blocks.

sihawken opened this issue 10 years ago · 43 comments

sihawken commented 10 years ago

For some odd reason, minetweaker breaks when it comes to LogisticsPipes blocks. This isn't my first script, so I'm 90% it wasn't an error on my part. I've described the entire issue over on MineTweaker3's issue tracker, but I think its probably something that Logistics Pipes is doing. Another person has confirmed that they had the same issue.

Even values provided by an NEI dump didn't work. I am a bit confused.

The issue I posted was here: stanhebben/MineTweaker3#164

SonOfTheStars · Answer 1 · 2015-03-23T00:30:42.000Z

What actual error code are you Getting?
Can you provide the error Log from Minetweaker?

sihawken · Answer 2 · 2015-03-23T07:23:17.000Z

This is the log from the LP.zs file that is causing the issue: http://pastebin.com/WntexhAi

weirdly enough, I can see why it can't resolve it. It is searching for

LogisticsPipes : logisticsSolidBlock : 1

when it should be searching for

LogisticsPipes:logisticsSolidBlock:1

which is what I have set in LP.zs . This behaviour is odd, it only happens with Logistics Pipes :/ I have about 10 other scripts, each per mod. The other ones work well.

Dream-Master · Answer 3 · 2015-03-23T08:36:40.000Z

I have the same problem with logistic pipes version 0.8.... and 0.9.....

SonOfTheStars · Answer 4 · 2015-03-23T22:14:51.000Z

That doesnt seem like somethign related to LP, it seems something with the Script is not working correctly. Make sure you have the latest version of Minetweaker.

Because its not something that a Block is not resolvable, its rather that there is a method missing in the Scripting Engine!

Dream-Master · Answer 5 · 2015-03-23T22:54:05.000Z

I using the last Minetweaker (3.09c)version and the last mod tweaker (0.7.5)Version. Every script works except logistic pipes. Are logistic pipes using a different Method than other mods?

Dream-Master · Answer 6 · 2015-03-23T23:33:02.000Z

Then i don't know how LP recipes can be resolved via Minetweaker?

SonOfTheStars · Answer 7 · 2015-03-23T23:34:32.000Z

ive definitly had stuff working before so I can confirm you this isnt something thats on LP´s side, since we Use normal Block registering, same with Items...
(I changed all the recipes before I actually came around implementing the Beta Recipes for the 0.9 Version)

SonOfTheStars · Answer 8 · 2015-03-23T23:11:49.000Z

Nope, LP uses just the Same stuff as every other mod ;)
There is nothing special in particular that could break such funktionality.

Dream-Master · Answer 9 · 2015-03-24T00:04:28.000Z

I make a minetweaker addon for Gregtech and run it in my pack. I think this can't be the error because the other guy don't use it. I post tomorrow a minetweaker log file.

Dream-Master · Answer 10 · 2015-03-25T11:49:29.000Z

Here the proof:

recipes.remove(<LogisticsPipes:logisticsSolidBlock>);

ERROR: LP.zs:1: Could not resolve <LogisticsPipes : logisticsSolidBlock>
ERROR: Error executing LP.zs: null
java.lang.NullPointerException
    at minetweaker.mc1710.recipes.MCRecipeManager.remove(MCRecipeManager.java:94)
    at LP.__script__(LP.zs:1)
    at __ZenMain__.run(LP.zs)
    at minetweaker.runtime.MTTweaker.load(MTTweaker.java:157)
    at minetweaker.MineTweakerImplementationAPI.reload(MineTweakerImplementationAPI.java:624)
    at minetweaker.MineTweakerImplementationAPI$1.execute(MineTweakerImplementationAPI.java:82)
    at minetweaker.MineTweakerImplementationAPI$19.execute(MineTweakerImplementationAPI.java:610)
    at minetweaker.mc1710.server.MCServer$MCCommand.func_71515_b(MCServer.java:124)
    at net.minecraft.command.CommandHandler.func_71556_a(CommandHandler.java:94)
    at net.minecraft.network.NetHandlerPlayServer.func_147361_d(NetHandlerPlayServer.java:739)
    at net.minecraft.network.NetHandlerPlayServer.func_147354_a(NetHandlerPlayServer.java:718)
    at net.minecraft.network.play.client.C01PacketChatMessage.func_148833_a(SourceFile:37)
    at net.minecraft.network.play.client.C01PacketChatMessage.func_148833_a(SourceFile:9)
    at net.minecraft.network.NetworkManager.func_74428_b(NetworkManager.java:212)
    at net.minecraft.network.NetworkSystem.func_151269_c(NetworkSystem.java:165)
    at net.minecraft.server.MinecraftServer.func_71190_q(MinecraftServer.java:659)
    at net.minecraft.server.MinecraftServer.func_71217_p(MinecraftServer.java:547)
    at net.minecraft.server.integrated.IntegratedServer.func_71217_p(IntegratedServer.java:111)
    at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:427)
    at net.minecraft.server.MinecraftServer$2.run(MinecraftServer.java:685)

It make space between the ":"

Every other Mods recipes i can remove and i have a lot of scripts

sihawken · Answer 11 · 2015-03-25T16:27:37.000Z

Hmmm, minetweaker should default to :0, but in my script that's what I did
and got the same issue.

I don't think that's the problem :/
On Mar 25, 2015 9:24 AM, "Bitterholz" [email protected] wrote:

Found your problem! In NEI, the Soldering Station and all other items that
are the First Subtype of an ID, are shown as "No Metadata".

But actually they are of Meta Value 0!

So instead of LogisticsPipes:logisticsSolidBlock you actually need to do:
LogisticsPipes:logisticsSolidBlock:0

That goes for ALL Blocks/Items that have subtypes. You allways register
the first Item as Value 0, because Subblocks are actually dealing with
Arrays and the first Entry in an Array is allways 0.

—
Reply to this email directly or view it on GitHub
#622 (comment)
.

SonOfTheStars · Answer 12 · 2015-03-25T16:13:31.000Z

Strange.. Ill doublecheck this

SonOfTheStars · Answer 13 · 2015-03-25T16:24:30.000Z

Found your problem! In NEI, the Soldering Station and all other items that are the First Subtype of an ID, are shown as "No Metadata".

But actually they are of Meta Value 0!

So instead of LogisticsPipes:logisticsSolidBlock you actually need to do:
LogisticsPipes:logisticsSolidBlock:0

That goes for ALL Blocks/Items that have subtypes. You allways register the first Item as Value 0, because Subblocks are actually dealing with Arrays and the first Entry in an Array is allways 0.

SonOfTheStars · Answer 14 · 2015-03-25T19:32:57.000Z

Because here at my Desk it just worked!

sihawken · Answer 15 · 2015-03-25T19:39:33.000Z

I'll have to try it again, but actually this is the variable I was using
and getting this issue:

LogisticsPipes:logisticsSolidBlock:1

As you can see in my script here: http://pastebin.com/iJ41bBcv

Following what you just tried, that should have worked. Maybe there is a
new minetweaker update or something. I'll write a new script and try it out.

SonOfTheStars · Answer 16 · 2015-03-25T19:26:40.000Z

It actually is! Its funny and retarded, but it is the actual Issue your scripts have there.

SonOfTheStars · Answer 17 · 2015-03-25T20:12:25.000Z

DANGER!
Stuff that Changes, AKA. the Recipe for a Block may only be a "var" not a "val" in your script! Because "val" is a final Value!

Dream-Master · Answer 18 · 2015-03-25T23:32:24.000Z

In my case I don't use a var a val. What you did mean with the value 0? How i can get my scripts working ?

sihawken · Answer 19 · 2015-03-26T00:20:31.000Z

I'm at work, so I can't test things at the moment. However, what bitterholz is saying is that you have to specify the metadata of the block: this is because multiple blocks can share the same ID. Simple way to do that is to append :<meta> to the end, where if the metadata is 3, you would enter it as modname:block:3 I thought you didn't have to specify it as 0 if the metadata was 0, but apparently you do. The weird thing is that I was specifying :1, for the power junction. Once I'm off work I'll try again with the newest minetweaker and logistics pipes

SonOfTheStars · Answer 20 · 2015-03-26T01:54:40.000Z

@Dream-Master :
You need to do:
var lpBlockSolder = LogisticsPipes:logisticsSolidBlock:0;

You allways NEED to specify Metadata, if Metadata is a thing for that Block your dealing with.
Metadata usually starts with 0, wich is the case if there are metadata Blocks on the same ID, but the first Block is show WITHOUT any Metadata.

So IF there is a Block without Metadata that defenitely has Subtypes, for Example Minecraft Log-Types, LP-SolidBlocks and many more, you HAVE to specify:

itemOrBlockWithMeta = ModName:itemidentifier:0;

SonOfTheStars · Answer 21 · 2015-03-26T01:55:01.000Z

@simlhawk :
You need to allways specify the Metadata! even if its Zero, Otherwhise you would call an Item that is not Existent!
PLUS
If you plan on Changing a Recipe, you need to set your Variable as "var"!
Example:
//This needs to be "VAR"iable because we want to change the recipe!
var lpBlockPower = LogisticsPipes:logisticsSolidBlock:1;

All the recipe.something() functions ONLY work on VARIABLES, aka "var" prefix!

If you need an item just for the definition, for example Redstone:
//This doesn´t ever Change!
val MC_RSDUST = Minecraft:redstone;

var = Varibale, ANY changes require this
val = Final(Unchangeable) definition of an Item, just for shortening your Code and using one single refrence on the actual Item. You can basicly say these are CONSTANTS

Your error occurs because you tried recipes.remove(); on a CONSTANT. Thats why you get a NoSuchMethodException in your script.

Dream-Master · Answer 22 · 2015-03-26T09:08:51.000Z

@Bitterholz I will test it later. Thanks

Dream-Master · Answer 23 · 2015-03-26T11:01:27.000Z

I try this and it doesn't work :

recipes.remove(<LogisticsPipes:logisticsSolidBlock:0>);`

and this:

recipes.remove(<LogisticsPipes:logisticsSolidBlock:*>);

Error log:

ERROR: LP.zs:1: Could not resolve <LogisticsPipes : logisticsSolidBlock : 0>
ERROR: Error executing LP.zs: null
java.lang.NullPointerException
    at minetweaker.mc1710.recipes.MCRecipeManager.remove(MCRecipeManager.java:94)
    at LP.__script__(LP.zs:1)
    at __ZenMain__.run(LP.zs)
    at minetweaker.runtime.MTTweaker.load(MTTweaker.java:157)
    at minetweaker.MineTweakerImplementationAPI.reload(MineTweakerImplementationAPI.java:624)
    at minetweaker.MineTweakerImplementationAPI$1.execute(MineTweakerImplementationAPI.java:82)
    at minetweaker.MineTweakerImplementationAPI$19.execute(MineTweakerImplementationAPI.java:610)
    at minetweaker.mc1710.server.MCServer$MCCommand.func_71515_b(MCServer.java:124)
    at net.minecraft.command.CommandHandler.func_71556_a(CommandHandler.java:94)
    at net.minecraft.network.NetHandlerPlayServer.func_147361_d(NetHandlerPlayServer.java:739)
    at net.minecraft.network.NetHandlerPlayServer.func_147354_a(NetHandlerPlayServer.java:718)
    at net.minecraft.network.play.client.C01PacketChatMessage.func_148833_a(SourceFile:37)
    at net.minecraft.network.play.client.C01PacketChatMessage.func_148833_a(SourceFile:9)
    at net.minecraft.network.NetworkManager.func_74428_b(NetworkManager.java:212)
    at net.minecraft.network.NetworkSystem.func_151269_c(NetworkSystem.java:165)
    at net.minecraft.server.MinecraftServer.func_71190_q(MinecraftServer.java:659)
    at net.minecraft.server.MinecraftServer.func_71217_p(MinecraftServer.java:547)
    at net.minecraft.server.integrated.IntegratedServer.func_71217_p(IntegratedServer.java:111)
    at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:427)
    at net.minecraft.server.MinecraftServer$2.run(MinecraftServer.java:685)

Or i have to var all items first. I hope not.

Dream-Master · Answer 24 · 2015-03-26T11:06:12.000Z

Dont work with var too:

SonOfTheStars · Answer 25 · 2015-03-26T13:53:02.000Z

@Dream-Master may i have your whoole script + instance of minecraft?
Because i just ran a old script of mine, and it worked BEAUTIFULLY

Dream-Master · Answer 26 · 2015-03-26T19:14:11.000Z

@Bitterholz
I make only one line in the script(Logistic Pipes) I using Minecraft 1.7.10 and forge 1291. I using also many other scripts for my other mods.

My Modpack and scripts here.

https://github.com/Dream-Master/DreamCraft

What files you need more ?

Dream-Master · Answer 27 · 2015-03-26T19:15:24.000Z

And my two custom Mods i using

https://github.com/Dream-Master/Minetweaker-Gregtech-5-Addon

https://github.com/Dream-Master/DreamCraft-CoreMod

SonOfTheStars · Answer 28 · 2015-03-26T19:54:35.000Z

Maybe the G-Tech addon breaks something. Don´t know. I just tested it today and it worked for me...

I did:

var lpBlockPower = LogisticsPipes:logisticsSolidBlock:1;

recipes.remove(lpBlockPower);

That worked beautifully for me

Dream-Master · Answer 29 · 2015-03-26T20:37:50.000Z

I using the same code in G-Tech addon that Minetweaker use. i add only the missing machines. And why all other mods scripts working fine. So what is in LP different ? I don't get it why this error occurs.

SonOfTheStars · Answer 30 · 2015-03-26T23:19:25.000Z

I dont unmderstand it either XD maybe a Case-Sensitive mistake

bziemons · Answer 31 · 2015-03-30T17:07:32.000Z

As I understand and as Bitterholz points out: Minetweaker basically works.
If someone finds the issue and if it is actually fixable by changing something in LP, this is a valid issue.
Otherwise, as we are not officially supporting Minetweaker AND we do not have time to investigate every mod combination on earth, this issue will be closed when it gets inactive.

Dream-Master · Answer 32 · 2015-03-30T17:10:09.000Z

So what i can do to help finding this issue?

bziemons · Answer 33 · 2015-03-30T18:10:53.000Z

You could try it without Minetweaker addons first. You can try and get help from someone, who is very familiar with Minetweaker. I do not have experience with Minetweaker.

SonOfTheStars · Answer 34 · 2015-03-31T14:01:11.000Z

Dreammaster if you give me your instance of Minecraft, including all mods and configs, and a sheet of work you want to acomplish with MT, I can try and help you out with the scripts.

Dream-Master · Answer 35 · 2015-03-31T15:04:08.000Z

Let me try this out first by my self. I try it without mod Tweaker and my Mod. If it not work we go deeper inside. I let you know when I test it later this evening. Thanks for help.

Dream-Master · Answer 36 · 2015-03-31T19:43:01.000Z

@Bitterholz After a bit thesting i find out in this case it is my Mod that cause this error. I dont understund because my code have the same code than modtweaker only with missing fluid import and add some other Gt Machines. My Source Code is here. https://github.com/Dream-Master/Minetweaker-Gregtech-5-Addon and i link to my modpack i want to send you via pm. Thanks for help.
@simlhawk
It would be very interesting why you get this error. You are using my Mod GTTweaker?

SonOfTheStars · Answer 37 · 2015-03-31T23:00:39.000Z

Nope never heared of it :P

bziemons · Answer 38 · 2015-04-01T08:17:24.000Z

Thanks for testing. It is very likely that @simlhawk has a similar problem. Or his got solved from using metadata 0.

Dream-Master · Answer 39 · 2015-04-01T08:50:46.000Z

I try to using 0 but it don't change anything:-(

Dream-Master · Answer 40 · 2015-04-01T12:39:23.000Z

@Bitterholz what you mean with "Nope never heared of it :P"?

Dream-Master · Answer 41 · 2015-04-01T14:39:44.000Z

@hron84 But this Question goes to simlhawk !?!?

hron84 · Answer 42 · 2015-04-01T14:24:23.000Z

@Dream-Master i think it was the answer for your last question (You are using my Mod GTTweaker?)

bziemons · Answer 43 · 2015-04-01T19:50:48.000Z

Well you mentioned both people there. Perhaps just a misunderstanding? You shouldn't be surprised though.

Share to