Polymorphic item sink does not look at item of a locked empty JABBA barrel

Question

Polymorphic item sink does not look at item of a locked empty JABBA barrel

bziemons opened this issue 10 years ago · 7 comments

bziemons commented 10 years ago

Look if it is possible to get the item from a locked but empty JABBA barrel and still sink items of the type to that barrel.

Partly a bug, but might not be fixable.

bziemons · Answer 1 · 2015-04-26T19:49:30.000Z

That change looks inconsistent..

davboecki · Answer 2 · 2015-04-26T21:00:54.000Z

Why? The only places that ask for the method are Specific Interests and The Polymorphic ItemSink.

bziemons · Answer 3 · 2015-04-26T23:47:16.000Z

The current state is fine with it, but inconsistencies can break future code. Those two methods should not differ in the amount of item types they return. When you just look at their names (and/or the missing Javadoc) that does not make sense.

davboecki · Answer 4 · 2015-04-15T14:37:52.000Z

https://github.com/RS485/LogisticsPipes/blob/mc17/common/logisticspipes/proxy/specialinventoryhandler/JABBAInventoryHandler.java#L93
and
https://github.com/RS485/LogisticsPipes/blob/mc17/common/logisticspipes/proxy/specialinventoryhandler/JABBAInventoryHandler.java#L83
are probably the reasons why it currently isn't working.

SonOfTheStars · Answer 5 · 2015-04-15T14:41:32.000Z

So guess we probably only need to remove the itemstack.size>0
BTW are we handling TE Caches the same way?

davboecki · Answer 6 · 2015-04-15T20:56:35.000Z

Probably.
IIRC we currently don't handle TE Caches at all.

bziemons · Answer 7 · 2015-04-15T21:17:44.000Z

https://github.com/RS485/LogisticsPipes/blob/mc17/common/logisticspipes/proxy/specialinventoryhandler/JABBAInventoryHandler.java#L94
"items.stackSize-(_hideOnePerStack?1:0)" should not make it -1 though.

And it is needed to see where the methods are used and to see, if the check for the itemstack size is needed there instead.

Share to