![CensoredASM](https://media.forgecdn.net/avatars/thumbnails/358/827/256/256/637520208754289091.png)
onDemandAnimatedTextures conflict with Optifine
xemnes opened this issue · 22 comments
unsure why this is happening, a LOT of textures are no longer animating, such as water and animations on blocks from most mods (it might be all of them? not sure edit: some textures are still animated, ie: teleporter effect in rftools).
a lot of models in immersive engineering are broken, steel posts and other machine multiblocks look very weird
https://i.imgur.com/UsK24Gy.png
conveyor belts are showing missing textures
https://i.imgur.com/62ceaRT.png
as well as most machine blocks from thermal series
https://i.imgur.com/t04KcsU.png
ducts render invisible
https://i.imgur.com/ON75w9T.png
edit: also noticed some other blocks dont render textures correctly anymore
such as smelteryio fuel controller which is missing its face
https://i.imgur.com/IZ3wwGg.png
also seems to completely break fluidlogging on all blocks with fluidlogged api.
Try restarting your game and see if most of those fix, just in case, send me your log file.
sadly restarting didnt fix any of the mentioned problems
heres my log
latest.log
:
i wonder if its your implementation of texfix? i opted to not install it a while back as there didnt seem to be much of a difference in performance when i last used it and it did break some stuff in similar ways but i cant remember.
ah yes, i just installed 5.2 and i can confirm most things have been fixed
blocks are once again fluidlogged
models from immersive engineering are no longer looking wacky
ducts are visible
no missing or broken textures
except for the animations which are still static
Update:
When i disable this option, issue gone:
B:onDemandAnimatedTextures=false
ah hmm, out of curiosity, how much of an improvement on performance does this option give when enabled?
Tried replicating but animations are all fine with onDemandAnimatedTextures = true
.
is that with optifine? if not, then i will try narrow down which mod may be causing it
No, not with Optifine. Optifine has its own Smart Animations
which does the more or less the same thing but more invasively. You can turn off LoliASM's onDemandAnimatedTextures
when using Optifine's Smart Animations
.
Optifine invasively patches minecraft classes. I haven't had time to check if the patches I make conflict with OptiFine's, but it probably is.
Smart Animations
was disabled on my side. So no animations with
Smart Animations: false
onDemandAnimatedTextures: true
Optifine invasively patches minecraft classes
Little bit offtop, but i though you just copy-past VanillaFix code to Loliasm 😅
But seems like its not, because VanillaFix haven't such problem.
OptiFine overwrite Minecraft's classes, simple-as. And no, if I just copied over VF's code, we would still have the issue such as Tinker's smelteries not having animated textures.
can confirm that was an issue, i had to disable it in vanillafix to fix that issue with smelteries. optifine has always been known to be extremely mod unfriendly, and it doesnt help it is closed source also.
Can confirm that this setting prevents most blocks from displaying their animations no matter what (vanilla fire, chisel blocks, thermal fluids, techguns items).
And unfortunately disabling this setting isn't an option for users with AMD GPUs, the FPS hit is quite high unless they run Optifine's "Smart Animations".
Closing to make #113 the main onDemandAnimatedTextures
thread.