Would it be possible to fix this minecraft bug?
SonicX8000 opened this issue · 4 comments
Minecraft: 1.12.2
Figure I ask since in a closed issue that I was looking at, you mentioned some MC related fixes and this got me wondering...
In case you wanted to know what closed issue I was looking at, it was this one.
#90
Anyways... onto the question.
https://bugs.mojang.com/browse/MC-63720
So... I was wondering if this vanilla minecraft bug could perhaps be fixed. Banners overtime... as well as some modded items like the Watch of Flowing time from ProjectE stop moving as time goes by. In early worlds they will sway in the wind or animate but in older worlds... they will being to 'lag' to the point where they just... won't move at all. Here are some gifs.
This is with the Time value close to 0, upon viewing the value with an NBT Editor... it was at 2111. The banner here sways in the wind as usual.
I edited the Time value to 1000000696956 that was mentioned in the bug report and... now banners no longer sway in the wind. The only fix for this is to reset the time back to a lower value with an NBT Editor.
Some modded items will also be effected by this, such as the Watch of Flowing Time from ProjectE and I believe the Rockets in JEI if you had Galacticraft installed. Again, this depends on how much time went by as the banner & other objects will begin to slow down overtime to the point of not moving at all.
Ah, didn't know about Sledgehammer having the fix, and yea... unfortunately it's only for the vanilla-related stuff after checking it out.
Banner's fixed, but Watch of Flowing Time from ProjectE still remains static. (The Clock is suppose to bob up & down while spinning, much like a dropped item does.)
Prob more items from other mods are affected, but Galacticraft Rockets in JEI was one other mod that I recall currently.
Check out Sledgehammer:
https://www.curseforge.com/minecraft/mc-mods/sledgehammer
It has something addressing this:
# If 'true', fixes banners freezing when the world is old enough (MC-63720).
banner-freezing=true
Sledgehammer has a lot of fixes for vanilla issues like these (full disclosure, many of which I contributed).
Unfortunately, the buggy logic has probably been copied into a lot of mods so simply patching the banner renderer like I did won't fix non-vanilla cases.
