LookingGlass

LookingGlass

470k Downloads

LookingGlass + MapWriter Bug

shadowfacts opened this issue ยท 5 comments

commented

When using LookingGlass to view a dimension (either using /lg-viewdim or via a Mystcraft Linking Book), the dimension that MapWriter (technically it's Opis) changes the current dimension to whatever dimension is being viewed.

commented

If anyone's interested, I've located the actual issue in Opis's version of Mapwriter. java/mapwriter/Mw.java:updatePlayer refers to the onWorldLoad event, which is supposed to determine what dimension the player is in. However, since LookingGlass needs to do things which trigger onWorldLoad for other dimensions, it assumes the player had just entered the dimension associated with the world that loaded.

commented

As in, MapWriter displays the wrong dimension number or the wrong map? Can you provide a screenshot?

commented

MapWriter displays the wrong dimension in its map, it assumes the player is in the dimension that was loading via LookingGlass.

This is an issue with MapWriter itself.

commented

That's interesting. Makes me wonder how MapWriter is pulling the world when rendering, and when it is rendering.
Sounds like it might be rendering during the actual world rendering. I'd recommend that, as a HUD overlay, it should render using the render tick, not a in-world render. However, I think LookingGlass is currently partially rendering the vanilla HUD, and shouldn't be. Changing that might fix it.
I take it back, hideGUI is on when rendering the proxy worlds. This issue is probably something MapWriter is going to have to fix.
As I understand it, JourneyMap works fine, so that's an option.

commented

That's good to know! :D
Unfortunately, I cannot do anything about that. The event MUST be called. Hopefully the assumption of "this must be the dimension the player is in" can be broken.