Lootr (Forge & NeoForge)

Lootr (Forge & NeoForge)

66M Downloads

[1.12] Not all chests converted in Villages

Krutoy242 opened this issue · 5 comments

commented

Not every vanilla chest converted into Lootr ones in villages.
About 80% of chests are still vanilla.
CONVERT_WORLDGEN_INVENTORIES work inconsistent. It increase conversion rates, but some chests still unconverted.

Im playing E2E-E modpack.

Examples

CONVERT_WORLDGEN_INVENTORIES=true
There is village with house. This house generated by Recurrent Complex. There literally 3 chests converted and one don't.

image

image

Unconverted chest have items in it:

image

There is another example. One house spawned with Lootr chests and other with vanilla:

image
image

I did it in new world and fly another 5000 blocks far. And there is still same buildings with one chest converted and other not:
image

commented

Unfortunately, the /data command wasn't added until 1.13. Can you confirm that the chests do indeed have a loot table associated with them? If they don't, then they aren't loot chests and won't be converted.

There are two ways to do this:

  • Open the chest and see if it contains anything (although this is not necessarily final as it may be a chest with items that are pre-determined).
  • Alternately, you could try opening it in spectator mode: if it's got a loot table, it should say "contents not generated yet" or something similar.
  • The more complex suggestion would be to use the Coordinate Calculator for Minecraft to work out which region file these belong to, and then something like NBT Explorer to open that region file, find the relevant chunk and have a loot through the chests to see if they have LootTable in their NBT data.

Alternately, checking the recurrent complex structure file should tell you whether it has a loot table or not; I know recurrent complex did chests in a complex fashion that generated contents when the structure was placed, rather than using a loot table: this may be the issue.

I failed to notice that you specifically stated the chests had items in them, disregard.

commented

The latest version of Lootr has custom support for Recurrent Complex loot tags, but I’m not sure if it will help in this case.

commented

As @embeddedt mentioned it's possible that hte newer version of Lootr for 1.12 might not be sufficient for Recurrent Complex. Unfortunately, it might just be something that you need to deal with, although I believe you could use the /lootr custom command (see the Wiki on commands) to convert the chests manually -- obviously this is non-ideal, but it's a potential solution.

commented

Please open a new issue if the latest version of Lootr for 1.12's Recurrent Complex support isn't sufficient.

commented

Ok, I will check it later. Week ago this problem was still actual.