Lootr (Forge & NeoForge)

Lootr (Forge & NeoForge)

59M Downloads

Support double chests

Jack-McKalling opened this issue ยท 4 comments

commented

When a regular double chest has a loot table and gets converted into a lootr-chest, only the half that has the loot will get converted.
But there should really be a double chest variant of the lootr-chest.

commented

I don't think there are double loot chests either, but I mean, when there is a chest that has loot in it, and another chest connects to it, eventhough it isn't both halves with loot, they do connect. If a loot chest forms a double chest, then regardless of the fact that the other half is "empty", it should still be converted to a double lootr-chest for the purpose of maintaining the double chest.

When this mod is used in modpacks, and there is a double chest occurrence (e.g. a vanilla spawner dungeon that happened to generate one), it just looks better if both halves are converted, or there would be two separate chests one of which has the fancy colours and the other one would just remain the normal vanilla one and be empty. It just doesn't look too good.

commented

I understand the aesthetic appeal, but code-wise double chests are a nightmare which involve a large amount of special-casing, as, in practice, it is two separate chests which are just given a single visual. I don't plan to support them any time soon, but it's a possibility for the future.

commented

As far as I'm aware, when it comes to Vanilla, unless you specify both halves of a double chest as loot, it will only generate loot for the first half.

I realize this is non-ideal but the frequency of double-loot chests wasn't particularly common when I started the mod, so I've not implemented them.

commented

Understandable. We can leave this open as long as you need/want.