Crash on server
HenrikoMagnifico opened this issue ยท 9 comments
Sometimes when loading new chunks on a server, the server hangs up and times out. It seems to be caused by Lootr.
Using the latest version of Lootr Forge on 1.19.2.
Thanks for the report! This is a bit frustrating and I'm not entirely sure what's triggering it -- I'm hopeful it's just some redundant code from previous versions that I can remove, but it may have to do with the recent changes I made to the block entity ticker to make it compatible with chunk generation mods.
If it's not too much trouble and you get a chance, would you be able to try the previous version of Lootr for 1.19.2 Forge, 0.4.25.67?
Would you actually be able to try this build: lootr-1.19-0.4.26.68.jar.zip?
You'll need to rename it from .jar.zip to .jar. It's the same version and should only need to be installed on the server. In theory this should fix it. I am also still curious if you get the error with the previous version.
What appears to be happening here is that a chest that is being replaced is very near to a chunk border (1 block away); when the chest is replaced, it updates the redstone signal of adjacent blocks, checking that those positions have a generated chunk at them.
Unfortunately, it then checks the additional positions to see if they conduct redstone and, if they do, signals to the next block in the chain -- without checking to see if that block is in a generated chunk. Hence, it can force chunks to load and cause the server thread to block.
The previous version of Lootr used a chunk cache that stored the positions of all generated chunks and avoided converting blocks when a 5x5 grid (with the original chunk in the center) wasn't fully generated. I removed this in favor of just using the provider's hasChunk method, which I hoped was identical, but it seems that may not be the case.
This would potentially break redstone so I'm going to go with another solution instead. I'll do a release for that shortly.
Did you get a chance to try this new version? If not, please don't worry, as someone pointed out my mixin may cause issues with redstone. I'm just going to fall back on the previous behaviour and release a new version shortly.
I am getting server crashes due to lootr as well on 1.20.1 Fabric
This always happens whenever i try to preload chunks using chunky
@Pinkietron Unfortunately, due to the number of bugs discovered recently, I haven't managed to port the changes for Chunky to Fabric. Please disable Lootr while using the Chunky pregenerator -- there is a disable option in the configuration -- and then re-enable once generation is complete.