Lootr (Forge & NeoForge)

Lootr (Forge & NeoForge)

59M Downloads

Holding dispatch command event is leaking Spark Server

pietro-lopes opened this issue ยท 2 comments

commented

Do you really need to hold this variable? I didn't find any reference that uses this.

It is causing Spark server to leak to main menu.

commented

Ah, interesting. This is a bit of a hold over from older versions where the command registration was different. I'll adjust how it handles the dispatcher.

commented

Resolved this by unfinalizing the dispatcher within the CommandLootr class and setting dispatcher to null after the registration is complete. I believe this should solve the issue. I'll include it in the next release (which will likely come after adjustments made to the API for integration with other mods).