Bad Gradle include snippet
Closed this issue ยท 10 comments
I suggest to replace this
repositories {
mavenCentral()
}
dependencies {
compile ("me.lucko.luckperms:luckperms-api:4.3")
}
with this
repositories {
mavenCentral()
}
dependencies {
implementation 'me.lucko.luckperms:luckperms-api:4.3'
}
implementation
configuration is faster than deprecatedcompile
.- There's no reasons to use GStrings when you don't need ${...} pattern syntax.
- Braces are not necessary.
You could always make a pull request, to make the changes then Luck can decide if the changes are good or not. Would be quicker than using an issue.
There's a repository containing all wiki pages.
You can contribute to that, to suggest changes. I sadly don't have a link, but it's either one of Luck's repos or one of the LuckPerms organisation.
It's here: https://github.com/LuckPerms/wiki
I'm fine with the changes, but don't really know enough about the implementation
configuration to say if it's valid or not.
@kashike almighty gradle master, any opinion?
@lucko Yes, api
and implementation
should be used instead of compile
now.