LuckPerms

LuckPerms

41.4k Downloads

True/False permission node change

LogicologistDev opened this issue · 12 comments

commented

Basically, on discord I was talking about this, and the mod said I should post it here.

Let’s say you set a permission for a player called test.
/lp user test permission set test.permission false

If I want to make that permission TRUE, Then I have to delete the permission, then I have to redo the permission with true at the end.

My suggestion is that you can toggle the permissions from true to false without resetting the permission.

commented

Do you mean toggle as in a new toggle subcommand, or as in overwriting the existing one when using set? Personally, I'd think the second one would be most useful because you could just set the permission regardless of whether they have it, but I suppose there could be some use cases for the first.

commented

I meant the set one

commented

This is definitely not the case on Sponge servers. If you set a permission, you do not have to remove it to change it. Not sure how it works for Spigot/Paper servers.

commented

It doesn’t work for spigot servers :P

commented

Just tested this. I'm running this on Spigot 1.13.2, LP version 4.3.73. Denying myself bukkit.command.op and then allowing it resulted in an allow. This functions as @PrincessRTFM described in their post.

Commands were run in this order:

/ess version
/perm user Foxtrek_64 permission set bukkit.command.op false
/perm user Foxtrek_64 permission set bukkit.command.op true
/perm user Foxtrek_64 permission info

image

commented

Some people here forget, that a web editor exists, where you can basically toggle the false to true and oposite :P
Just type /lp user <user> editor change the value, save and then use the generated command.
But I still agree that this could/should be an addition, if not already possible.

commented

I agree with PrincessRTFM. @TheRealLogical What is your server version and LP version? You can get these by running the following:

/version (or /ess version)
/lp info

If you could, give us these values or post a screenshot like I did.

Edit: also, a description of the behavior when you try to set a permission to true when it was previously set to false would be greatly beneficial. Command output, both in Minecraft and in the Console, if available, would be greatly appreciated.

commented

That web editor is great, but it's also a bit heavy for just changing one or two things - like if you forgot to add false at the end of a line - and it doesn't work right on all server rental services. In particular, MelonCube and their Multicraft control panel break the input so that you can't use the console to apply the changes. Furthermore, you can't script it, so you couldn't make an adventure server or something similar that toggles permissions on players without an intermediate unset command block.

In general, it's a decent alternative, but it's not of quite the same utility as this feature... request? (Given that it seems to work for some people, it may be a bug report instead...)

commented

I run LuckPerms on a 1.8.8 Spigot server. My luckperms version is 4.3.73.

commented

Please run the commands suggested in my last comment and provide us with the output of those commands.

Additionally, please provide us with the behavior your experience when trying to set a permission node to true when it had been previously set to false, as well as what you expect to happen.

commented

A haaa, I had forgotten this was added already! 😅

Since this commit, this behaviour should already be happening: d28170c

Also, talk of the web editor is irrelevant - I've hidden those comments.

Sooo, yes, seems like a bug if you're not seeing this behaviour already. @TheRealLogical Can you make sure you're using the latest version, and then give us the commands you tried to run.

commented

Will do, I’ll tell you if it works afterwards.