LuckPerms

LuckPerms

41.4k Downloads

Wildcards in sponge

XakepSDK opened this issue ยท 11 comments

commented

Can you please raise giant warning ASCII image, when someone uses wildcards, even if they are enabled in config?
Many people ask for help because of "unexpected" issues with wildcards.

commented

Not really needed. It's their problem when they use wildcard permissions.

commented

And with that ASCII image they will know, that this is their fault.
Current warning is not noticeable

commented

Having a big sign would be overkill and only spam the console more

commented

Also be aware that you will have to use wildcards when you're running a mixed network.

commented

I'm against adding this - they're an intended feature of the plugin, and implicit wildcards are an intended feature of Sponge.

I don't see why users should be warned about their use in such a "loud" manner.

commented

Then maybe add warning when they use * as permission?
Not parent.node.*, but just *
This literally breaks many plugins

commented

i was told by nucleus folks that any wildcard will cause issues whether nucleus or nucleus.* so I am confused. I would rather not have to write out a huge list of perms for my admins if I don't have to.

commented

@ktole1999 not related to this. Though the issues are plugin specific. Using wildcards works for some plugins, but not others. And Nuceleus is one of those plugins. (GriefPrevention is another (but for totally different reasons)). Nucleus provides a command that will setup the permissions for you. And GriefPrevention has a wildcard you can use.
Though in any case it is not LP's job to police your permissions. If some plugins have issues with global wildcards (any plugin with "negative permissions" (permissions you don't want/that turn something off rather than on)) or plugin wildcards (like nucelus or nucleus.*) then it's the job of those plugins to make the admins aware, not LP.

commented

fair enough, just trying to understand.

commented

It's not job of those plugins. Sponge does not forbids wildcard, but also does not tolerate them.
https://docs.spongepowered.org/stable/en/plugin/permissions.html
Check out note.

commented

Incorrect. All that says is that Sponge has never intended for Bukkit style wildcards to be implemented. Just LP does. Mainly for compatibility reasons.

And yes. If wildcards break a plugin (Talking about the default wildcards of the platform. nucleus breaks Nuceleus a bit. And griefprevention breaks GriefPrevention pretty much completely. And without LP) it is the plugin's job to make the admin at least aware (like GP does). Or to provide a convinient way to still setup permissions either through designated wildcards (like GP) or a command that sets up the individual permissions for you (like Nucleus).