LuckPerms

LuckPerms

41.4k Downloads

Verbose improvements

Tobi406 opened this issue ยท 8 comments

commented

Advanced filters

Some people have some sort of filter options they use every (or most) time(s) when using Verbose to reduce spam of specific plugins.

Possible Implementations

State: Needs discussion

  • Default filter in the config
  • Configurable filter lists (usable by inserting a special symbol.)
  • Example: #world & essentials (# is here the special symbol, but this can also be another symbol))
  • Could be made using a extra file
  • Maybe even modifyable using the API
  • Curent suggestions for filters:
    • f= like in Regex permissions
    • #
  • Both

Needed to complete (or better to have)

State: Needs discussion

  • Add a way to override set options in the default filters

Only show latest permission

Only show nodes checked since last turned off of Verbose

Possible implementations

State: Needs discussion

  • Config setting
  • Command argument
  • Both
commented

Additionally consider rate limiting in-game output.

commented

I think having it similar to the static context, where you have a separate file in which you can add and modify special filters would be a good way to go.

To then apply the filter maybe have a similar thing like the regex permissions where you prefix the filter with like f= to indicate that it is a saved filter.

Also if that would be added would I recommend to have a luckperms filter implemented that contains luckperms, prefix, suffix and meta.
The question now is how would we handle it like when someone wants to have one specific filter to both deny or accept?
Like a way to have like !luckperms &! meta &! prefix &! suffix but also luckperms | meta | prefix | suffix in one filter to filter for both if perm is with luckperms nodes or not.

commented

Regarding the default filter, I'd handle it like this:

  • If no filter is specified the default filter is used.
  • If a filter is specified the default filter is not used. But if one is defined the command sender will get a message like "Since you specified a filter your default filter is currently not being applied. Add & #default to the end of it to apply it too"
  • If #default is used in the filter that message doesn't appear.
commented

Regarding the default filter, I'd handle it like this:

  • If no filter is specified the default filter is used.
  • If a filter is specified the default filter is not used. But if one is defined the command sender will get a message like "Since you specified a filter your default filter is currently not being applied. Add & #default to the end of it to apply it too"
  • If #default is used in the filter that message doesn't appear.

I don't think we should have filters applied by default,
It should be a setting like a context one where the user can set up and use default ones.

commented

The point is that you can define your default filter. One that is empty by default.

commented

I think the default filter should be applied everytime, but can be disallowed using ! #default (or with whatever special symbol we go).

commented

Regarding priorities of things in Verbose. I think it shoulf be handled like this:

  • If two same nodes have been set, the value of the latest node will be taken
    • Example: luckperms &! luckperms. Checks for LuckPerms would not be taken (basicly it's getting to !luckperms)
commented

I drop this here since it's related to verbose but not quite about flags...

I personally still think there should be a config setting (or command setting) to set verbose on only showing checked permissions, that have changed since last check.
Scoreboard and Tablist plugins can and will cause a lot of permission checks and while plugins like FeatherBoard have already implemented a method to reduce those checks is it still not a 100% solved solution and we can't just assume that people know what filters they should apply to verbose...

So having this setting to only list permissions that have changed since the last check would imo be an improvement to LuckPerms and makes it less spammy.