LuckPerms

LuckPerms

41.4k Downloads

Change default value of "use-vault-server" from true to false.

emilyy-dev opened this issue ยท 0 comments

commented

Description

Please change the default value of use-vault-server to false ;-;
https://github.com/lucko/LuckPerms/blob/5e48224c78401f3ac25fa555ba63140f5a56e958/common/src/main/java/me/lucko/luckperms/common/config/ConfigKeys.java#L448-L451

Proposed behaviour

In the config file for the bukkit build, the pre-defined value is false and the context the plugin makes through Vault queries takes the server context from the server setting. If, for some reason, the setting isn't found, right now it'll default to true, taking the value of vault-server, which if it isn't found, will default to global, completely ignoring server contextual nodes on networks and can lead to a lot of confusion without having a clue on why the issue happens.
If it defaulted to false instead, it would just take whatever is in the server setting, not wrecking things.
Besides, since it's Vault we're talking about, it's (pretty much) Bukkit specific, it would also make sense for the default value to be "synced" with the pre-defined one in the provided config file.