LuckPerms

LuckPerms

41.4k Downloads

Issues with server reloads

djrranga opened this issue ยท 7 comments

commented

Description

LuckPerms throws errors when players change dimensions, but only after server reloads. This behavior was not present in LuckPerms 5.1.93.

Reproduction steps

  1. Start the server.
  2. Observe no errors or warnings.
  3. Reload the server with /reload confirm.
  4. Observe the errors and warnings below.

Expected behaviour

Should use player login/disconnect/change world events without throwing errors.

Environment details

  • Server type/version: Paper running version 1.16.3 build 206
  • LuckPerms version: 5.1.107

Warning immediately after server reload
Error upon changing world
Warning upon player disconnection
Error upon player login

commented

I'm making a plugin of my own and it's cumbersome to stop/restart the server every time I make a change. That's why I use reload. I never noticed any issues with LuckPerms before updating to the latest version, which is why I opened this issue.

commented

If you're making your own plugin AND you know it's reload-safe (save files, clear lists/maps, unregister event listeners, etc.), at worst you should use something like PlugMan or ServerUtils (this one I use when testing, recommended :p) to reload that specific plugin only (still not advised, never use it on prod).

commented

Alright, I guess I'll close the issue then.

commented

You shouldn't ever use /reload as it can cause issues like this.

commented

Never use reload. It's a despised feature that most plugins are NOT designed to cope with and things WILL break. https://matthewmiller.dev/blog/problem-with-reload/

You should always restart your server.

commented

/reload should never be used on a server you care about.

commented

Here's a hint. Why do you need to type /reload confirm? Because just /reload says specifically that this command should never be used, and things will break. When you run full /reload confirm, it repeats that before starting the reload. That's not for no reason. Ignoring warnings like this is how you get your server corrupted or damaged.