LuckPerms

LuckPerms

41.4k Downloads

'meta settemp' ignores the provided temporary modifier

emilyy-dev opened this issue ยท 1 comments

commented

Description

Trying to replace/accumulate a temp meta node on top of an existing one results in command failure because "Player already has temp meta".

Reproduction steps

  1. Set a temporary meta node
  2. Try setting it again on the same holder with accumulate as temporary modifier
  3. It no work

Expected behaviour

I would expect it to:

  • If using accumulate to add the time to the existing node
  • If using replace to, well, replace the expiry time.

Environment details

  • Server type/version: Paper running version 1.16.5 build 567
  • LuckPerms version: v5.3.14

image

Any other relevant details

The command checks for existing nodes already (temp or not) before adding the new node, effectively ignoring the temporary modifier.
https://github.com/lucko/LuckPerms/blob/2e62c98c4564683e5ba7af367173413739e89dcb/common/src/main/java/me/lucko/luckperms/common/commands/generic/meta/MetaSetTemp.java#L82-L92

commented

Merged your PR, thank you :)