LuckPerms

LuckPerms

41.4k Downloads

Calling setPermission on group subjects doesn't always save

bloodmc opened this issue ยท 6 comments

commented

As title states, whenever I attempt to call setPermission on group subjects, it doesn't always save to storage. Player subjects have no issues.

Tested with LP 3.2.20

commented

I'm still thinking about the best way to solve this. I know what the issue is, but there's a few ways it could be fixed.

Rest assured I haven't forgotten, just don't want to rush a crappy (potentially more broken) solution.

It's also kinda linked to #317, so I might end up implementing a solution to both issues in one go, and fix the root of the issue in common, instead of working around it in the Sponge module.

commented

Should be fixed.

commented

OK it seems like if I let it sit for awhile, the permission is eventually applied. So the issue is, why do group permission set/unsets take much longer than players randomly?

commented

@lucko just tested build 3.3.20 and this appears to still be an issue.

I'm testing with json storage and running the following command

https://github.com/MinecraftPortCentral/GriefPrevention/blob/master/src/main/java/me/ryanhamshire/griefprevention/command/CommandHelper.java#L482

This doesn't always work properly with groups. I'll have to execute my command multiple times in order to see it work. However, sometimes it works instantly.

commented

Might be an issue with the way i/o via Sponge is being buffered.

commented

Should be fixed (kinda) by: d60d0ac

I want to avoid removing the buffering completely, as it completely kills the storage whenever plugins try to make bulk changes to permissions.