LuckPerms

LuckPerms

41.4k Downloads

Push release artifacts to github to get cleaner, deterministic URLs

aaronjamesmarshallau opened this issue ยท 2 comments

commented

Description

Currently, it's difficult to incorporate LuckPerms releases into CI pipelines with version-based variables (using an environment variable to update LuckPerms, for example) as artifacts are downloaded directly from your CI platform (Jenkins), which includes the build number in the URL.

Moving towards using Github releases (or similar) allows for deterministic URLs that can be better integrated with CI pipelines. It looks like you do use Github releases, but currently only for minor versions and not revisions.

Proposed Behaviour

Upon a new release being created, the artifact should be uploaded to Github releases under that version.

Extra Details

This is something that some other plugin creators do, including Vault and Essentials. This has made it easy for us to manage these versions for our server using Ansible.

I imagine that this isn't a priority, but it would be nice to have.

commented

Hey ๐Ÿ‘‹

LP uses rolling releases - each commit on the master branch is a new version.

I periodically publish "stable" (using this term loosely) releases to other platforms like the Spigot forums, but there's no defined moment/reason when this happens. It's basically just when I feel like there are significant enough changes waiting.

I'm reluctant to do the same with GitHub Releases (i.e. as a manual step occasionally) as it's extra work that has to be done manually! Automating it (i.e. on each commit) seems a bit spammy too.

So I guess, my suggestion for your automation would be to always download + install the latest version. You can use this endpoint to do that: https://metadata.luckperms.net/data/downloads

Hope that helps :)

commented

Cheers for taking the time to reply. I'll take a look and see if it's something we can integrate. I'm sure a bit of jq can help me here ๐Ÿ˜…

If this isn't something you think you'll address (like, ever), feel free to close this issue ๐Ÿ˜