Added parents failing to save after confirmation message
Rasgnarok opened this issue ยท 1 comments
Description
When I look at history, I can see that LP definitely gave 'Omen', yet the user reported not having Omen - so I added it again manually, which worked. It shouldn't have however, because 'Omen' was never removed, as you can see in the logs below.
Here are the logs when Omen was first given:
[04Jul2022 03:09:03.824] [Server thread/INFO] [BuycraftX/]: Dispatching command 'lp user KoreanNino parent add omen' for player 'KoreanNino'.
[04Jul2022 03:09:03.824] [Server thread/INFO] [BuycraftX/]: Dispatching command 'lp user KoreanNino parent remove rune' for player 'KoreanNino'.
[04Jul2022 03:09:03.825] [Server thread/INFO] [Console/]: [LP] Another command is being executed, waiting for it to finish...
[04Jul2022 03:09:03.827] [luckperms-command-executor/INFO] [Console/]: [LP] KoreanNino now inherits permissions from omen in context global.
[04Jul2022 03:09:03.828] [luckperms-command-executor/INFO] [Console/]: [LP] KoreanNino no longer inherits permissions from rune in context global.
[04Jul2022 03:09:29.892] [Server thread/INFO] [Console/]: i[Jade]i Nino: oh fuk no
Omen has a greater weight than Jade, which is how the player noticed his Omen hadn't applied
He reported it to me, and 20 minutes later, from console before fixing,
[03:28:54] [luckperms-command-executor/INFO] [Console/]: [LP] KoreanNino's Parents: (page 1 of 1 - 3 entries)
[03:28:54] [luckperms-command-executor/INFO] [Console/]: > default
[03:28:54] [luckperms-command-executor/INFO] [Console/]: > great
[03:28:54] [luckperms-command-executor/INFO] [Console/]: > jade
See in the logs below to show how the /lp user KoreaNino parent add omen command did not fail despite the fact there was no logs of it being removed following LP's confirmation message of addition.
Reproduction Steps
Can't be reproduced every time, seems to be related to the command executed through console. See https://discord.com/channels/241667244927483904/241667244927483904/993617113728163890 for Discord report.
Expected Behaviour
/lp user KoreanNino parent add omen
should add omen after confirming, aka
[luckperms-command-executor/INFO] [Console/]: [LP] KoreanNino now inherits permissions from omen in context global.
then
/lp user KoreanNino parent info
[luckperms-command-executor/INFO] [Console/]: [LP] KoreanNino's Parents: (page 1 of 1 - 3 entries)
[luckperms-command-executor/INFO] [Console/]: > default
[luckperms-command-executor/INFO] [Console/]: > great
[luckperms-command-executor/INFO] [Console/]: > omen
Server Details
arclight-1.16.5-1.0.24
LuckPerms Version
v5.4.25
Logs and Configs
Extra Details
