LuckPerms

LuckPerms

Mods
905k Downloads

Group names not passed verbatim to Vault

MilesBHuff opened this issue · 2 comments

commented

Description

Group names are not being passed into Vault verbatim, and this is causing issues downstream.

Reproduction Steps

  1. Make roles called pathfinder, pathfinder+, etc. (https://github.com/SettleScape/server/tree/master/minecraft/plugins/LuckPerms/yaml-storage/groups)
  2. Set those up for EssentialsDiscordLink (https://github.com/SettleScape/server/blob/master/minecraft/plugins/EssentialsDiscordLink/config.yml#L44-L56)

Expected Behaviour

Essentials should understand that + is an integral part of the role name.
The Essentials team looked into this, and found that LuckPerms was not providing the correct names to Vault.

Server Details

git-Paper-411 (MC: 1.17.1) (Implementing API version 1.17.1-R0.1-SNAPSHOT) (Git: 6625db3 on ver/1.17.1)

LuckPerms Version

5.4.102

Logs and Configs

[00:22:29] [Server thread/WARN]: [EssentialsDiscordLink] Invalid group pathfinder+++ was provided for role 699859069112156161. The following groups are available: [owner, pathfinder, pathfinder, moderator, tester, monitor, pathfinder, pathfinder, booster, administrator, wanderer, volunteer, donor, wanderer, explorer, settler, traveller, player]
[00:22:29] [Server thread/WARN]: [EssentialsDiscordLink] Invalid group pathfinder++ was provided for role 699859069112156161. The following groups are available: [owner, pathfinder, pathfinder, moderator, tester, monitor, pathfinder, pathfinder, booster, administrator, wanderer, volunteer, donor, wanderer, explorer, settler, traveller, player]
[00:22:29] [Server thread/WARN]: [EssentialsDiscordLink] Invalid group pathfinder+ was provided for role 699859069112156161. The following groups are available: [owner, pathfinder, pathfinder, moderator, tester, monitor, pathfinder, pathfinder, booster, administrator, wanderer, volunteer, donor, wanderer, explorer, settler, traveller, player]

Extra Details

  • EssentialsX version: 2.20.1
  • Vault version: 1.7.3-b131
commented

I see that your pathfinder+* groups have a displayname.pathfinder node, by default LP will use the group's display name when handing the group name over Vault (because they are often used for, well, displaying), you can change that behaviour with the vault-group-use-displaynames setting

LuckPerms/bukkit/src/main/resources/config.yml

Lines 643 to 647 in 84fce98

# If LuckPerms should use the 'display name' of a group when returning groups in Vault API calls.
#
# - When this option is set to true, the display name of the group is returned.
# - When this option is set to false, the standard name/id of the group is returned.
vault-group-use-displaynames: true

  • ❤️1
commented

Thank you! That did the trick!