Description

I have observed a significant performance issue while using LuckPerms on my server. After pulling a report using Spark, I discovered that LuckPerms is causing lag, especially when the server has 50 players online. The lag appears to be due to the way LuckPerms handles command tree updates and player permission checks.

Reproduction Steps

Install LuckPerms on a server running the Fabric mod.
Have at least 50 players online at once.

Expected Behaviour

LuckPerms should handle permission updates and command tree management efficiently, even with a large number of players online.
There should be no noticeable lag or performance degradation when updating permissions or sending command tree updates to players, especially when there are 50 players connected simultaneously.

Server Details

fabric-server-mc.1.20.1-loader.0.16.10-launcher.1.0.1 fabric-api-0.92.2+1.20.1

LuckPerms Version

5.4.102

Logs and Configs

No response

Extra Details

No response

It's not clear to me that this is an LP issue. Looks like NMS/Fabric to me. See https://spark.lucko.me/docs/Using-the-viewer for reading Spark reports - this one shows LP taking less than 0.01% of the resources (displays as 0%) over NMS.PlayerManager#sendCommandTree