LuckPerms

LuckPerms

41.4k Downloads

Sometimes group parent add commands in an import are ignored.

JethroHotep opened this issue · 2 comments

commented

I have a deep group hierarchy, and group parent add commands in the import file are randomly ignored with no error messages. For instance, I do an export and get this:

# Export group: rank110
/lp group rank110 permission set displayname.Outlaw true
/lp group rank110 permission set ezranks.rank.Outlaw true
/lp group rank110 parent add default
/lp group rank110 meta addprefix 110 Outlaw
/lp group rank110 permission set pvpmanager.pvpstatus.change true

# Export group: rank120
/lp group rank120 permission set displayname.Gunslinger true
/lp group rank120 permission set ezranks.rank.Gunslinger true
/lp group rank120 parent add rank110
/lp group rank120 meta addprefix 120 Gunslinger

but after importing into an empty system, I export again and get:

# Export group: rank110
/lp group rank110 permission set displayname.Outlaw true
/lp group rank110 permission set ezranks.rank.Outlaw true
/lp group rank110 parent add default
/lp group rank110 meta addprefix 110 Outlaw
/lp group rank110 permission set pvpmanager.pvpstatus.change true

# Export group: rank120
/lp group rank120 permission set displayname.Gunslinger true
/lp group rank120 permission set ezranks.rank.Gunslinger true
/lp group rank120 meta addprefix 120 Gunslinger

The "/lp group rank120 parent add rank110" command from the first export is missing from the second export. I have confirmed that the actual parent is missing after the initial import by using shell queries and by directly reviewing YAML files (I tested with similar results for both H2 and YAML.).

It is not always the same parents missing, and I can then reimport the full export again, and it restores some of the missing parents, but of course with lots of duplicate errors.

Here is the full export/import and subsequent export.

Exported this file, then Imported it into an empty system.
lp201803261629.txt

After importing the file above, this is an export for comparison.
lp201803261655.txt

Testing with LuckPerms-Bukkit-4.1.25.jar.

commented

Built LuckPerms-Bukkit-4.1.43.jar and the problem seems to be resolved, though I don't see the issue for it. Have to assume it was fixed as a side effect of a general improvement or another issue. You can close this. Thanks for the great plugin!

commented

It was fixed in 4773934
Corresponding issue was at #833

Kudos to you for thinking to check using a dev build, most wouldn't bother ;)

I'll push the change to spigot shortly.