Add support for Fabric

Question

Add support for Fabric

kristibektashi opened this issue 4 years ago · 16 comments

kristibektashi commented 4 years ago

alexsocha · Answer 1 · 2021-01-03T02:36:38.000Z

It's highly unlikely that this will ever happen, unless one day fabric becomes considerably more popular than forge. Supporting 2 different mod loaders at the same time is just too impractical, and disadvantageous for the whole modding community.

teddyxlandlee · Answer 2 · 2021-01-24T06:19:07.000Z

@alexsocha The answer might be yes in 1.16.x. As a Fabric player and modder, I love Lucky Block too. However, I cannot play other mods while playing Lucky Block. That's annoying.
Support for Fabric might not be toooooo hard for Lucky Block, as it depends on structures, world generations and mob NBTs. I think you can just develop the "first version" of Lucky Block for Fabric, and let contributors do the long time supports.
Support for Fabric is not disadvantageous for the whole modding community; in fact, it can improve what people think of Lucky Block. People like me will have more choices on choosing and playing mods. Many mods support two different mod loaders or above, such as REI, VoxelMap, etc.
That's my advice. Hope it can help you.

kristibektashi · Answer 3 · 2021-02-14T09:04:24.000Z

Still waiting

kristibektashi · Answer 4 · 2021-02-15T07:53:27.000Z

@alexsocha

Ecorous · Answer 5 · 2021-03-03T14:25:27.000Z

I could help code it even

alexsocha · Answer 6 · 2021-03-07T00:44:28.000Z

Sorry for the delay - I recently tried fabric and I must say I’m impressed. It appears to be growing in popularity, and overall it’s probably a better piece of technology.

The biggest challenge here is keeping most of the codebase the same across both loaders, so that future maintenance is not 2x the work. I think that with some API abstractions, Kotlin rewrites, and gradle trickery, this is completely doable. Expect a Fabric version in the coming weeks!

kristibektashi · Answer 7 · 2021-03-13T13:32:25.000Z

@alexsocha How is Fabric support coming along?

alexsocha · Answer 8 · 2021-03-14T04:07:57.000Z

refactoring, refactoring...

xfoscarz · Answer 9 · 2021-04-08T14:38:27.000Z

fabric... pog

Ecorous · Answer 10 · 2021-04-09T18:02:12.000Z

@alexsocha How about now? I can help if needed

alexsocha · Answer 11 · 2021-04-11T00:20:23.000Z

Should be done in a week or so

kristibektashi · Answer 12 · 2021-04-15T07:37:28.000Z

@alexsocha When will I be able to download Lucky Blocks for Fabric?

Ecorous · Answer 13 · 2021-04-16T10:25:44.000Z

Soon @kristibektashi

alexsocha · Answer 14 · 2021-04-20T14:32:18.000Z

Done: #22, and it's now up on the website

Ecorous · Answer 15 · 2021-04-21T17:51:30.000Z

I say this should be reopened. There isn't any addon functionality in the fabric version for what I can see

alexsocha · Answer 16 · 2021-04-22T07:16:36.000Z

Addons should work just the same as in the forge version, I've made sure to test this heavily. Please do let me know if there are problems though. Otherwise, except for a bit of remaining docs work, I'd say that this is done in general, and you can always open separate issues to address more specific problems

Share to