MacOS Input Fixes

MacOS Input Fixes

969k Downloads

Incompat with MinecraftClientGoBrr

Tempest-5ky opened this issue ยท 3 comments

commented

Crash on startup, seems to be an incompat with this mod?: https://modrinth.com/mod/minecraftclientgobrrr

Crashlog: https://mclo.gs/ZGhriLa

if it's their fault lmk and i'll post the issue there instead!

commented

@Zensonaton it seems like MinecraftClient.window doesn't get set by your mod here.

Is there a reason you are not just shadowing the window field and setting it? You seem to have created your own window field instead.

commented

@Zensonaton it seems like MinecraftClient.window doesn't get set by your mod here.

Is there a reason you are not just shadowing the window field and setting it? You seem to have created your own window field instead.

I did this because I thought that there is no chance that window field with 'early' window would be used anywhere, so this is why I did this.

I'll fix that in the next update if I won't get into any troubles.

commented

I've made the fix locally, I'm going to push those changes to my repo soon.

I think that you should mark 1.0 version of my mod in your fabric.mod.json as 'breaks':

"breaks": {
    "minecraftclientgobrrr": "<=1.0"
}