Make it compatible with 'Smooth Scroll Everywhere'
stantios opened this issue · 28 comments
Description: Currently when both 'MacOS Input Fixes' and 'Smooth Scroll Everywhere' are in the same mods folder / instance, it normally defaults to this mods scroll fix which in my opinion it should not do. Instead when both mods are present in the instance, maybe make it so it uses 'Smooth Scrolling' instead of the fix for MacOS scrolling.
The issue is that this mod groups scroll events together because otherwise you can have issues with selecting items in your hotbar iirc. I'll look to see about toggling the grouping code when it's in the game itself only, this should fix it for 99% of cases I think (including scrolling on any minecraft options menus for example).
Can you tell me if you're experiencing issues with a mouse or a trackpad? That mod doesn't seem to work well with trackpads at all. (I think I've fixed it anyway, but just curious where you're experiencing issues)
I believe version 1.3 should make this work properly, please let me know if it doesn't and re-open the issue.
You shouldn't need an option to make it work, but you need version 1.3. Have you tried it? What isn't working for you (compared to not having this mod), and is it with mouse or trackpad or both?
I just tried it out, and it seemed to not work. The thing that's not working is scrolling through the mods menu screen or the controls screen. When I only have the 'Smooth Scrolling' mod on, it scrolls through mody vanilla menus smoothly and quickly but when I have both mods, the scrolling is quite slow and it's not as smooth. Also, I'm only using a mouse
Actually, to fix the slowness, try adjusting the scroll sensitivity option in mouse options (which is a setting from Minecraft, and shouldn't interfere with hotbar scrolling).
No, I was only staying examples of where it doesn't work. It doesn't work everywhere else as well, and yes I'm on 1.19.3
Ok, so just to check, you're saying that it doesn't scroll in the mod menu screen (from the mod menu mod), and the controls screen, but it works everywhere else (e.g. hotbar, creative inventory, and video options screen)? Also just confirming you're on 1.19.3. To fix the slowness, try enabling the "momentum scrolling" option in the settings for the mod (which are in the mouse settings menu), this will likely mess with hotbar scrolling, but just ignore that for now.
Can you please list where you have actually checked, especially if it works on the hotbar as expected (ie. 1 scroll on the mousewheel moves 1 item). Can you also try the scroll sensitivity option to see if that helps with the speed, will worry about smoothness afterwards if that's still an issue.
Please check at least: the hotbar (to see if 1 scroll on the mouse = 1 movement left or right), creative inventory, video options screen, and controls screen. Please check them all with scroll sensitivity = 1 (the default), and with scroll sensitivity = 6 (you can adjust this later if you want).
So, everything is normal with the screens and I've tried to adjust the scroll sensitivity but it feels either too fast or too slow. Scroll Sensitivity = 1 is just right but scrolling throught things like the Mod Menu Screen, Controls Screen and the Video Options feel slow compared to without the MacOS Input fixes mod and only having the Smooth Scrolling mod on.
The scroll sensitivity option should give you fine adjustment how fast Minecraft scrolls through those menus, adjust it to whatever value feels about right. Unless I'm misunderstanding you, you're saying that with scroll sensitivity = 1 feels too slow, and with scroll sensitivity = 6 it feels too fast, if that's correct, just try some other options in between until it feels right. Other than that it should basically be the same as without the mod (ie. MacOS Input Fixes only vs vanilla feels basically the same now to me on these sorts of menus iirc).
Here's a version with a change I'm testing that I think probably fixes this (which would be under a toggleable option), let me know if it fixes your issue (you'll need to extract the jar file out of the zip).
macos-input-fixes-1.3.jar.zip
I'm saying that Scroll Sensitivity = 1 feels right but in certain menus like the ones I listed in my previous message, the scroll feels slow and not as smooth.
I think there should be an option to disable your scroll tweak on certain menus if that is possible.
Cool, I'll add that as an option in a 1.3.1/1.4 update. I'll do it tomorrow though as it's 10.30pm here already.
Wow that is late, you should probably get some rest. Anyway, thanks for helping me put with this issue and I appreciate you help!
I've implemented the feature, along with another feature (tooltips on hover to explain each of the options), but I'll release it sometime tomorrow (if all goes well) as I want to do some code refactoring first, and I need to thoroughly check it works on every version.
That's great to hear, I was going to suggest to add tooltips to each options to help the user understand what each option does.
I wanted to add them before, but it is a bit of a pain due to how I use the one jar for 1.14-1.19.3 (1.14 and 1.15 actually don't have tooltips currently as there isn't an obvious API to me for me to use, I may revisit this in the future though) (here's the commit if you're interested, probably only ~50 of those lines are for the interface smooth scroll feature, most of which is the same lines basically as other options that need to modify the native code logic; the refactoring I want to do is to de-duplicate some of the class, method, and field resolution and lookup code in there).