Magical Jewelry

Magical Jewelry

501k Downloads

[BUG] [1.20.1] Infinite duration of effects and stackables

DankestO opened this issue · 4 comments

commented

Versions (Be specific, do not write "latest"):

  • Magical Jewelry: 1.20.1_1.6.0
  • Curios: 5.2.0-beta.3+1.20.1
  • Forge: 1.20.1 - 47.1.0

Describe the bug
For some reason, when I put an accessory on and take it off, the effects are still there, and not only that, but if I re-equip the same accessory, the effects stack.

To Reproduce
I thought it could be that I modified:
maxEffectLevel = 3
and
epicAmount = 0
legendaryAmount = 0

I thought that would be it, because that happened on my dedicated server, and in singleplayer it did not happen to me, but after trying different combinations in the configuration I did not get reliable results, the bug sometimes appears shortly after entering the world again and equipping myself an accessory, sometimes everything works perfectly, but other times it doesn't.

commented

Did you change the config file after you had already equipped some jewels? If so, then that would have been the problem I think. Just to confirm, did this only happen on the server, or did you also experince it on singleplayer?

commented

Oh my god, you're right, if I change that while playing sometimes the effects stay there, I'm so dumb xDDD
Possibly I changed it without realizing it, I have been modifying files for a personal datapack.

And about the question, first it happened to me on the server, and then in singleplayer trying different combinations with the configuration trying to recreate what happened.

commented

No worries, it have been an issue from the start and I haven't been able to find a good solution for it yet, other than maybe a re-write. I will take another look at it, soon-ish I hope. But if you change the config before equipping any jewels, it should be fine :)

commented

Hello again, maybe you already know this, but I wanted to say it just in case.
When you use the /reload command on the server this problem also appears. I just found out.
It made me curious because I had not touched the config file and I remembered that I had done before.
Btw, thanks for this great mod and for your help with this problem :)