Majrusz's Accessories

Majrusz's Accessories

6M Downloads

Issue with Accessories tagging, KubeJS, FTB Quests (Forge, 1.19.2)

katubug opened this issue · 12 comments

commented

Hi! My co-developer was trying to write a quest explaining the basics of your mod, using the latest version with the 1.20 backport items.

They used KubeJS to add a "forge:majrusz_accessories" tag to many of the mod items, and then added an FTB Quest to require one of the items in that tag - something we do frequently. Unfortunately, the tag shows as broken and containing no items, despite the fact that the items ingame show that the tag has been added.

We then attempted to make a quest using one of your items and selected the "curios:pocket" tag, which also showed as broken. We then tested using an item from the Artifacts mod, and it worked correctly. We figure the issue must have something to do with the way your items are using tags, but we're not sure what could be different. I confirmed that everything was done correctly on their end, and we also combed through the latest.log and found nothing special about tags not loading, or anything to do with the word "majrusz."

Let me know if there's any other information we can provide, such as if you need the log or anything. Thanks for your time!

commented

latest.log in question
2024-03-05_14 47 57

latest.log

commented

Not all defined tags for registry ResourceKey[minecraft:root / minecraft:item] are present in data pack: forge:maj_accessories

They used KubeJS to add a "forge:majrusz_accessories" tag

maj != majrusz

I'm assuming you also did sth. wrong when using the pocket tag
https://www.curseforge.com/minecraft/mc-mods/lmft for more info about broken tags

commented
commented

just to clarify: not my mod, just another user

if the curios:pocket tag was empty / broken then you wouldn't be able to equip the items themselves into said slot
it is a very normal implementation which is the same for all curios items

sounds like a configuration issue on your end / issue from ftb quest

commented
commented

to be completely clear: the tag "works" in the sense that things which have this tag can be searched and referenced using this tag. But as Katu said, we just get a broken texture when using the tag in FTB Quests. this is the code in question, placed in the item section of my kubejs tags file:

// Majrusz's Accessories

event.add('forge:maj_acs',
'majruszsaccessories:certificate_of_taming',
'majruszsaccessories:idol_of_fertility',
'majruszsaccessories:lucky_rock',
'majruszsaccessories:tamed_potato_beetle',
'majruszsaccessories:angler_trophy',
'majruszsaccessories:discount_voucher',
'majruszsaccessories:dream_catcher',
'majruszsaccessories:metal_lure',
'majruszsaccessories:miner_guide',
'majruszsaccessories:adventurer_kit',
'majruszsaccessories:tool_scraps',
'majruszsaccessories:unbreakable_fishing_line',
'majruszsaccessories:adventurer_rune',
'majruszsaccessories:angler_rune',
'majruszsaccessories:household_rune',
'majruszsaccessories:miner_rune',
'majruszsaccessories:nature_rune',
'majruszsaccessories:soul_of_minecraft',
'majruszsaccessories:secret_ingredient',
'majruszsaccessories:swimmer_guide'
)

// Majruzs's Boosters
event.add('forge:maj_boosters',
'majruszsaccessories:onyx',
'majruszsaccessories:dice',
'majruszsaccessories:owl_feather',
'majruszsaccessories:golden_dice',
'majruszsaccessories:golden_horseshoe',
'majruszsaccessories:horseshoe'
)

// Majruzs's Cards
event.add('forge:maj_cards',
'majruszsaccessories:gambling_card',
'majruszsaccessories:removal_card',
'majruszsaccessories:reverse_card'
)

commented

i'm assuming its due to missing creative tab entries

https://github.com/latvian-dev/item-filters/blob/41edd14ae270bd32fa34b3281e8221148e8fe97f/common/src/main/java/dev/latvian/mods/itemfilters/DisplayStacksCache.java#L39-L48

you cant find the items through the search and that seems to be a criteria for the filters

commented

I appreciate your willingness to help, but as it is exclusively this mod that we have the problem with, and we've tested many variables, we'd just like to confer with the mod dev on this issue. Thanks.

commented

Hello, I am not very familiar with how KubeJS and FTB Quests work, but I can confirm that accessories in my mod are added in a custom way to have multiple copies of the same accessory with different tags. @SiverDX discovered that these mods filter items based on their visibility in search bar in creative mode menu and thats where we have incompatibility. Thank you all for reporting that, I will prepare a compatibility fix within next few days

commented

Thanks for your response! Glad we could get this sorted! :D

commented

I have made all items properly accessible through creative mode menu ad0911f and released a new backport version. It should fix your issues, but I keep the thread opened until you confirm it