MalisisCore

48M Downloads

Hotbar changes lighting appearance if slot is empty

Dockter opened this issue ยท 1 comments

commented

See screenshots for issue: If the hotbar is selected on a slot that is empty, the entire hotbar's lighting shade goes darker than it is when the hotbar is rendering an item (on a select slot with an item).

http://www.almuramc.com/images/gui/darkSlot.png

http://www.almuramc.com/images/gui/lightSlot.png

My hack fix to resolve issue: I commented out lines:

https://github.com/Ordinastie/MalisisCore/blob/master/src/main/java/net/malisis/core/client/gui/MalisisGui.java#L386

and

https://github.com/Ordinastie/MalisisCore/blob/master/src/main/java/net/malisis/core/client/gui/MalisisGui.java#L387

I am assuming there is a different place to resolve this issue, this was the first "fix" I came to.

commented

@mcsnetworks @Ordinastie

This is actually a non-issue. Its because we are "faking" GuiScreen as the in-game HUD (by calling drawScreen in the tickloop). The code in MalisisGui for enabling lighting is very much correct from the standpoint that they are actually GuiScreens but not from the prespective of an In-Game GUI

AlmuraDev/Almura@3250dd3

This commit fixes it. I've tested with different blocks and opening Minecraft GUIs...no noticeable lighting mistakes I've found.