MalisisDoors

MalisisDoors

48M Downloads

[1.8.9] MalisisCore & MalisisDoors - memory leak.

MrGraphic opened this issue ยท 6 comments

commented

Forge .1764
MalisisCore 2.1.1
MalisisDoor 3.1.1

Took me a while to isolate issue from the whole pack. Apparently there is a "hole" somewhere. Byte and Char arrays growing way beyond normal state.
Totally fresh save, no blocks of interest in world, standing still, vanilla plus core and doors.
Fancy picture from profiling:
m_core_door
and for comparison vanilla plus thaumcraft:
m_core_door_tc_c

commented

I had multiple report of memory leaks from MalisisDoors, but I haven't been able to find out from where it comes. I'll keep looking though...

commented

Unfortunelly I can't provide more details.
Heap is filling even if only MalisisCore is in enviroment.

commented

Ok, first of all from what I have seen so far dev env is somekind of a "magic place" where even if you cut half the code things will still work as expected hehe ;).
Second, it seems that the last commit did the trick and perm gen does not swell anymore :D. Fantastic job!
Screen from heap dump as instrumented :
classes

commented

Ok, I may have found a leak, but it doesn't really makes sense for your test case.
First, that's what I have : http://puu.sh/nM9Lo.png. As you can see, memory doesn't really ramp up, and that's in dev, with all my mods together.
Anyhow, I found some objects piling up in memory, but that happens when new chunks get loaded on the server, which doesn't really apply in your test case.

However, if you manage to find the time to redo your test, but when done, perform a Head Dump.
For that dump, on the Classes tab, if you can filter with the word "malisis" and screen that, I could confirm that I did find the leak.

commented

I was hoping for the buggy screen, but if you say it's fixed, I'll trust you :)

commented

Hehe, we will see in "real life" case ;).