Malum (Quilt)

Malum (Quilt)

1k Downloads

Injection error crash

Sunconure11 opened this issue ยท 14 comments

commented

I may have found a solution on my side, would you be available to test it out if I attached here the jar?

commented

This is because of an issue with Soul Fire'd.

https://www.curseforge.com/minecraft/mc-mods/soul-fired

@nyphet

commented

Hi, I'm quite new to mixins, how did you determine the injector conflict was because of Soul Fire'd?
Anyway it does make sense as I indeed inject at that point of code with @Redirect annotation.
Unfortunately, no idea on how to fix this on my side at the moment.

commented

Both of you are using getFireAspect in some way.

commented

And in your case @Nyphet, it seems you are altering it in such a way that causes conflicts with the two mods.

commented

I believe the crash is happening because Redirect and ModifyVariable injectors refer to the same target, mine just happens to be applied after and overrides Malum's one.
The same problem would happen if my injector was applied first and Malum's one was applied after, it just depends on the loading order.
I'm looking for a solution that chains injectors rather than overriding them, but I'm not sure that it's applicable for this case.

commented

I should be able

commented

soulfired-1.19.2-1.1.0.0-fabric.zip
Try out this version and let me know if it still crashes and whether it works or not, thank you (you need to unzip it to get the jar)

commented

It runs!

commented

Great! Then by the end of this week I will release the new version, thank you for reporting the issue and testing the solution!
You can close the issue now

commented

@Nyphet Error returned with the new Curse build.

commented

The same exact error? That is weird, I uploaded on Curseforge the same jar I attached here.
Can you show again the logs?

commented

The launcher is not picking up on the version.

commented

I just checked and versions for 1.19.1 and 1.19.2 are still under review. It may need some time before they become available, I don't have any control on that as it solely depends on the Curseforge team.