Malum (Quilt)

Malum (Quilt)

1k Downloads

Crash when placing item on any pedestal.

Aquaeyes opened this issue · 11 comments

commented

crash-2022-06-01_14.11.55-server.txt
Tested on all pedestals, when reloading the world the item is present on the pedestal as expected.

commented

Also occurs when a hopper is inserting or extracting an item, or when right clicking to retrieve an item yourself. Does not occur when breaking the pedestal, and the item is dropped normally.

Also with spirit crucible, twisted tablet, spirit catalyser. And item stands, and placing spirits in spirit jars. Additionally, items only render as single items when multiple are in the inventory? (Unsure if bug or not)

commented

the original malum mod had it show one item too

commented

what I believe is happening is that my DefaultedInventory system (which implements what I want for all my inventories) has these methods/functions
image
instead of every custom block defining what its position is etc, I use the stuff that exists on the base block entity (which every block entity builds off) to get the world etc, for some reason these aren't named correctly or something which causes them to not be implemented

commented

I also cannot reproduce this could you provide more explicit instructions?

commented

Running with Quilt 0.16.1-1.18.2. qsl-1.1.0-beta.13_qfapi-1.0.0-beta.16_fapi-0.53.4_mc-1.18.2, malum-fabric-b1.0.1, trinkets-3.3.1 and I'm not quite sure.

  1. Create/load a world
  2. Place any item-holding block from Malum
  3. Place an item into it, crash.
  4. Load world after the crash
  5. Item should be present in the block as desired.

Not quite sure how to help recreate it in your environment, as I can't ever not reproduce it.

Edit, would it help if I record the bug occuring?

commented

can you try this with the newest build from https://github.com/RealRTTV/malum-fabric/actions/runs/2422019370
and yea sure you can record the bug

commented
commented

oh yea I gotta fix that, it happens every time asljdklasd, there's a new version building rn

commented

does it exist on the newest build?

commented

arathain may have solved the issue
¯_(ツ)_/¯

commented

so 12 days later I realize that having my functions to get the world (and pos etc) is auto-overridden since they're the same name, but as soon as the game is played in a build jar form, the names swap from getWorld() into method_10997() which means it isn't auto-overridden and has to be manually done