[BUG][1.18.2] Runewood/Soulwood leaves' distance block property is always 1 when grown
thetos7 opened this issue · 5 comments
Malum version: 1.3.7
What happened
When malum trees grow naturally or with bonemeal, the distance property of leaves is always set to 1, however, it should be set to the distance (26-neighbourhood distance1) to the nearest log, like vanilla trees do. This happens correctly when growing the trees with the Create mod's tree fertilizer.
Examples
Incorrect distances (grown with bonemeal)
The distance value should be 2.
Correct distances (grown with the Create mod's tree fertilizer)
Oak tree for comparison
Steps to reproduce
- place runewood sapling or soulwood sapling
- grow the sapling (wait or bonemeal)
- inspect leaves' block properties with F3 (right side)
Footnotes
-
schema of 26-neighbourhood on page 3: https://arxiv.org/pdf/1803.04190.pdf ↩
The distance values (for runewood trees) seem to be initially set to 1 here:
Yeah hmm, I kind of put this problem aside when developing the feature at first. I don't think it's too big of a deal.
If I don't set it to 1, I believe some of the leaves would start to decay instantly, which made the trees look bad. I'm not sure what the best solution here is.
It's minor I guess, during normal gameplay with malum only, it doesn't affect much, leaves decay normally and stuff. However I think this breaks the behavior of Create's saws, for example, which do not break all the leaves currently (they should).
So it may only create minor incompatibilities.
I don't even understand why this happens but like, if I don't force the leaves into a distance of 1 they just get thanos snapped after the game ticks a bit.