Potential NPE in Mantle when an inventory is queried early

Question

Potential NPE in Mantle when an inventory is queried early

asiekierka opened this issue 10 years ago · 3 comments

asiekierka commented 10 years ago

bonii-xx · Answer 1 · 2014-11-23T17:22:33.000Z

That probably was one of tinkers crafting tables that was hooked up to a buildcraft pipe on an old TCon version. When they updated the inventory size got changed (crafting tables actually had a bigger, invisible, non-accessible inventory) the pipes still have the old size cached and therefore crash. I can't really return something else than null for a nonexistant slot.
Since there is no exception in that trace I can't even tell if that's the problem.

bonii-xx · Answer 2 · 2014-11-23T22:24:04.000Z

I've had it happen before. When I did that change.
Could also try the latest mantle-build which has an additional check. But only works if it's actually the same issue. ;)

asiekierka · Answer 3 · 2014-11-23T20:23:32.000Z

Generally, you should return null on invalid getStackInSlot values, however, I will look into that theory.

Also, the person implied it happens on world load, and BC definitely does not cache inventory sizes in NBT...

Share to