Map Atlases [Fabric]

Map Atlases [Fabric]

208k Downloads

Pins disappearing

Qct00 opened this issue ยท 10 comments

commented

people keep complaining on my server, that every time they log off and log back on their pins disappear.

commented

can you try and see if it happens on a server with just the mod on?

commented

I cant replicate. I tested on fabric version on a server.
Can you verify the mod is saving stuf in the map_atlases folder?
look in your instance directory /map_atlases/multiplayer folder. there should be some files named with the ip of the server

commented

Hi. I'm having this problem on my server and checked and it is not adding any files to the multiplayer folder. What can I do to fix this? I appreciate the help!

commented

I can confirm. The folder didn't create itself.

commented

@MehVahdJukaar So, all of our pins are getting removed. I did some cursory reading over your code, and I can only assume something is going wrong here:

(that is, assuming it is being called at all, which an extra debug log would be very helpful with).

I'm not getting an error logged related to markers not being saved. It might be good to add a separate case here when the path is null, and log a warning? I don't see a case where this should happen, so it'd be good to log.

Is there any way to verify the load call went through correctly? And are markers stored client-side, or server-side? Where should I be able to find them (if they were actually saving)? That'd help me pinpoint whether they're being saved, and not loaded, or whether they're not being saved at all.

commented

yeah

commented

I have som experimental changes here. Please try it out and verify it creates a folder with a name that should match the sever adress in map_atlases/multiplayer
map_atlases-1.20-6.0.11.zip
map_atlases-1.20-6.0.11-fabric.zip

Rename .zip to .jar because GH wont let me upload that here

commented

Will do! Is this on a branch so I can check it out? :)

commented

@MehVahdJukaar Seems to have fixed it. Thanks for the quick response!

commented

Finally nice