Mariculture

Mariculture

2M Downloads

Localization change

Adaptivity opened this issue · 19 comments

commented

For the proper translation in Russian I need different color names for "mariculture.lamps.format" string.

commented

Yes, it so. BUT I need to change ending of colors for "mariculture.lamps.format". Russian variants of "mariculture.pearl.color.white" unsuitable for "mariculture.lamps.format".

commented

I'm not sure I understand? It uses the colours from mariculture.pearl.color.white etc

commented

Can you give me examples . I am so confused xD.

Do you have different words for a colour based on certain things? As in White Pearl, and White Pearl Lamp would have an entirely different word for 'White'. Otherwise I'm lost.

commented

White Pearl Block -> "Белый жемчужный блок" (In Russian)
White Neon Lamp -> "Белая неоновая лампа" (In Russian)
As you can see color words have different endings: "-ый" for block or brick, "-ая" for lamp.

commented

Something I'll keep in mind for the future, but right now... I'd rather just let 1.X pass on. I'll do it when I have a bunch of bugs to fix :P

commented

Ok. Will wait.

commented

So, can you do this?

commented

The way this will work it will look for a translation for

pearl.color.yellow.lamp
pearl.color.yellow.block
pearl.color.yellow.pearl
pearl.color.yellow.brick

and if it cannot find the relevant translation it will use the default of pearl.color.yellow
So feel free to add these translations. (They won't be in the english lang)

commented

Ok, thanks.

commented

Will just wait on this, then I'll upload the new version.

commented

Few more requests for improving translation:

  1. Pearls seems to be localized like: Color + mariculture.pearl. Can they use unique names? Like "mariculture.pearls.pearlwhite"?
  2. Rings, Bracelets, Necklaces seems to be localized like: "Color" + Pearl + ring/bracelet/necklace. Can you add %s tag to item. name? I need swap item name with color and pearl.
    Reopened for some time.
commented

About release... well, can we at least fix all missing names in en_US.lang? There a lot of them.

commented

What ones?

commented

As for the pearls you already have "mariculture.pearl.format" and then you can edit "mariculture.pearl.color.yellow.pearl" etc.

commented

I'll send a PR to fix missing names soon. Can you make something for rings/bracelets/necklaces?

commented

Yes, working on that

commented

Thanks, I knew there was some I had missed when I messed with everything xD

commented

How to use rings/bracelets/necklaces formats? Provide an example if possible.
Also, mariculture.onering should be mariculture.oneRing

commented

I can't fix some of missing names. Better you should do it. I'll make a list for you:

  1. mariculture.upgrade.format (I don't know for what it needed)
  2. mariculture.plans.redstone (should be maritech.plans.redstone)
  3. mariculture.string.water (just water)
  4. mariculture.FishingRod (Wooden fishing rod?)
  5. mariculture.net.net (don't know)
  6. mariculture.RodBlood (should be fixed in .lang file)
  7. mariculture.sands.gas
  8. All corals
  9. mariculture.MobMagnet
  10. mirrors/rings/bracelets/necklaces names