More Axolotl Variants Mod (C&C Backport Add-On)

More Axolotl Variants Mod (C&C Backport Add-On)

48k Downloads

[Fabric] Can't start BMC server when PC language is set to certain languages

jmadarg opened this issue · 11 comments

commented

When the PC language is set to Turkish and you try to run a BetterMC the server, it is not able to start because of mavm, specifically with this error:

image

Seems to have problems with the name lucıa
image

Its the second time I've seen this reported on the Luna Pixel Studios' discord, the first time was also with Turkish and this was their log: https://mclo.gs/acYy5kG

Minecraft version: 1.19.2

commented

Could you tell me if the test jar file inside this zip fixes the crash? Hope it works. Please tell me so i can release the fix.
More Axolotl Variants Mod Locale Fix.zip

commented

Thanks for the quick fix! The person having the issue is gonna test it later because they are at work rn

commented

Alright.

commented

The person who had the issue hasn't responded me with the results yet, but I tested it on my machine running the server with the JVM flag -Duser.language=tr and it isn't working. It shows the same error.

image

commented

Then I don't understand why is happening, because the variant doesn't even have accent, is called "lucia".

commented

I did some digging and it seems that the problem is because of Turkish using special characters (I with a dot and i without a dot) so the method toLowerCase() is actually converting I to i without the dot and I noticed you were using toLowerCase(Locale.ROOT) on the file you sent, which has the same behavior.

Not sure why the fabric server doesn't like that, but the top answer on this stackoverflow question recommends to use toLowerCase(Locale.ENGLISH) to force the expected I to i conversion, ignoring the user locale.

Tried to test it, but didn't manage to clone and build the project correctly, I'm still too new to Java.

commented

Ok, just did that change. Hope it's fixed now.
More Axolotl Variants Mod Locale Fix 2.zip

commented

Tried it, the issue persist.
image
Maybe that first call to toLowerCase() is messing with it, as its not specified to use English?

commented

Didn't realize i've put that.
More Axolotl Variants Mod Locale Fix 3.zip

commented

It works fine now! Thanks!

commented

Pushed in latest update.