Mc2Discord

Mc2Discord

50.4k Downloads

Intermittent Double Advancements in discord

Mx772 opened this issue ยท 4 comments

commented

This may be a duplicate of #47. However, I'm on 3.1.2, so it should be fixed.
mc2discord-forge-1.16.x-3.1.2.jar

Logs aren't showing any errors. Have Webhook mode on. Worked fine on 3.1.0.

Intermittently double messages:

image

Most config here is default:

	[[Channels.Channel]]
		id = 123 (fake)
		subscriptions = ["info", "chat"]
		use_webhook = true

Sidenote: it logs the following even while on 3.1.2:
New version available: 3.1.2

commented

Double down with the 'Duplicate advancement after 30 minutes':
image

This reminds me of a weird issue with Websockets where I didn't ack the send everytime, so everything got duplicated. But not sure if you are using sockets. Either way, maybe the above will help you narrow down the issue!

Also - Duplicate messages with and without webhook enabled.

commented

Hi thanks for your issue,
First the esay part :

it logs the following even while on 3.1.2:
New version available: 3.1.2

Mostly a forge version checker bug please ignore :)

Now the second part : the duplicate advancement. I have no idea why this started just now (it got reported a few days ago on discord) on a version that was running fine for a long time. I may need to update the discord library (who manage the socket and all the discord stuff) but not sure to have time this week :)

But I can't see anything in both Mc2Discord and Discord4J (the library) that can create a 30 minutes delay, that's way to much. May be it's another mod that duplicate the advancement event ?

Denis

commented

Yeah, most of the time, there is a miniscule delay. Occasionally, there is a really long delay.

Working with slack's socket API before (Similar, but different) I've seen weird behaviors like that, where my application was getting socket events much later, or after re-establishing a connection, I'd get a duplicate event.

But in this case, I basically updated from v3.1.0 without issue. On v3.1.2 it suddenly was 'most advancements get duplicates'. (The ones that do duplicate, are not even mod-specific or something weird.)

And most of the time, if they duplicate, the second message is almost instant.

Imma see if bumping down to v3.1.0 fixes it. Haven't had much time to investigate it much, but I could also see it being an interaction.

Will report back my personal findings too. But if others are seeing it, I wonder if it's something weird with the Library.

commented

Self solved / solved on discord