Bag Of Souls not working with the following mods installed

Question

Bag Of Souls not working with the following mods installed

AragoonKappa opened this issue 3 years ago · 10 comments

AragoonKappa commented 3 years ago

Pretty much the title. I get the exact same amount of experience when mining blocks of quartz, whether I have Bag Of Souls 3 or not.

Mods are as the following :

    - additionalbanners 7.0.4
- additionalentityattributes 1.0.0+1.18.2 via spectrum
- advanced_runtime_resource_pack 0.5.7 via modern_industrialization
- advancednetherite 1.4.1-1.18.2
- adventurez 1.4.10
- alloy_forgery 2.0.11+1.18
- ambientsounds 5.0.16
- appleskin 2.4.0+mc1.18.2
- aqupdgrizzly 1.18-1.3
- architectury 4.1.36
- artifacts 7.0.3+fabric
- attributefix 14.0.1
- basicshields 1.3.1-1.18.2
- bclib 1.4.3
- betteranimalsplus 1.18.2-11.0.5
- betternether 6.1.0
- betterthanmending 1.3.0
- blue_endless_jankson 1.2.1 via kyrptconfig
- bookshelf 13.0.13
- bosses_of_mass_destruction 1.3.6-1.18.2
- campanion 3.0.4
- capybara 1.0.3
- cardinal-components 4.1.4
- cardinal-components-base 4.1.4 via cardinal-components
- cardinal-components-block 4.1.4 via cardinal-components
- cardinal-components-chunk 4.1.4 via cardinal-components
- cardinal-components-entity 4.1.4 via cardinal-components
- cardinal-components-item 4.1.4 via cardinal-components
- cardinal-components-level 4.1.4 via cardinal-components
- cardinal-components-scoreboard 4.1.4 via cardinal-components
- cardinal-components-world 4.1.4 via cardinal-components
- chas 1.18-1.8-Fabric
- cloth-basic-math 0.6.0 via cloth-config
- cloth-config 6.2.57
- clumps 8.0.0+7
- com_electronwill_night-config_core 3.6.3 via enchantinginfuser
- com_electronwill_night-config_toml 3.6.3 via enchantinginfuser
- com_eliotlash_mclib_mclib 18 via geckolib3
- com_eliotlash_molang_molang 18 via geckolib3
- com_flowpowered_flow-math 1.0.3 via dimdoors
- com_github_dimensionaldevelopment_poly2tri_java 0.1.1 via dimdoors
- com_github_llamalad7_mixinextras 0.0.7 via artifacts
- com_typesafe_config 1.4.1 via croptopia
- comforts 1.1.2-1.18.2
- conjuring 1.0.22+1.18
- creativecore 2.6.10
- croptopia 2.0.0
- crowdin-translate 1.4+1.18.2 via basicshields
- curse_maven_wthit-3707010 440979 via dimdoors
- darkutils 10.0.2
- dimdoors 4.0.4
- dragonloot 1.0.10
- drinkbeer 3.0.2
- duckling 1.0.3
- ecologics 1.4.0
- elytratrinket 3.0.0-1.18.1
- enchant_giver 1.1.0 via mcdw
- enchantinginfuser 3.2.0
- endlessocean 0.2.0-BETA
- expandability 6.0.0 via artifacts
- expandedstorage 7.3.11
- fabric 0.51.1+1.18.2
- fabric-api-base 0.4.4+d7c144a860 via fabric
- fabric-api-lookup-api-v1 1.6.0+2373a54560 via fabric
- fabric-biome-api-v1 8.0.4+7b0f312660 via fabric
- fabric-blockrenderlayer-v1 1.1.12+3ac43d9560 via fabric
- fabric-command-api-v1 1.1.9+d7c144a860 via fabric
- fabric-commands-v0 0.2.8+b4f4f6cd60 via fabric
- fabric-containers-v0 0.1.21+d7c144a860 via fabric
- fabric-content-registries-v0 3.0.3+d82b939260 via fabric
- fabric-convention-tags-v1 1.0.1+474e4f7960 via fabric
- fabric-crash-report-info-v1 0.1.11+3ac43d9560 via fabric
- fabric-dimensions-v1 2.1.17+2540745460 via fabric
- fabric-entity-events-v1 1.4.8+d7c144a860 via fabric
- fabric-events-interaction-v0 0.4.19+d7c144a860 via fabric
- fabric-events-lifecycle-v0 0.2.14+d7c144a860 via fabric
- fabric-furnaces 2.1.1-1.18.2
- fabric-game-rule-api-v1 1.0.13+d7c144a860 via fabric
- fabric-item-api-v1 1.4.0+4457765560 via fabric
- fabric-item-groups-v0 0.3.11+91896a4960 via fabric
- fabric-key-binding-api-v1 1.0.12+54e5b2ec60 via fabric
- fabric-keybindings-v0 0.2.10+b4f4f6cd60 via fabric
- fabric-language-kotlin 1.7.1+kotlin.1.6.10
- fabric-lifecycle-events-v1 2.0.3+2d83e92c60 via fabric
- fabric-loot-tables-v1 1.0.11+d7c144a860 via fabric
- fabric-mining-level-api-v1 2.1.0+81ea5b3c60 via fabric
- fabric-models-v0 0.3.6+d7c144a860 via fabric
- fabric-networking-api-v1 1.0.21+d882b91560 via fabric
- fabric-networking-v0 0.3.8+b4f4f6cd60 via fabric
- fabric-object-builder-api-v1 2.1.0+fe4ddef060 via fabric
- fabric-particles-v1 0.2.12+526dc1ac60 via fabric
- fabric-registry-sync-v0 0.9.8+0d9ab37260 via fabric
- fabric-renderer-api-v1 0.4.13+d882b91560 via fabric
- fabric-renderer-indigo 0.5.0+7faf0d8860 via fabric
- fabric-renderer-registries-v1 3.2.11+b4f4f6cd60 via fabric
- fabric-rendering-data-attachment-v1 0.3.7+d7c144a860 via fabric
- fabric-rendering-fluids-v1 2.0.2+54e5b2ec60 via fabric
- fabric-rendering-v0 1.1.13+b4f4f6cd60 via fabric
- fabric-rendering-v1 1.10.7+54e5b2ec60 via fabric
- fabric-resource-conditions-api-v1 2.0.3+91b7aa6660 via fabric
- fabric-resource-loader-v0 0.4.18+2de5574560 via fabric
- fabric-screen-api-v1 1.0.10+d882b91560 via fabric
- fabric-screen-handler-api-v1 1.2.0+1f6558e860 via fabric
- fabric-textures-v0 1.0.12+3ac43d9560 via fabric
- fabric-transfer-api-v1 1.6.0+2373a54560 via fabric
- fabric-transitive-access-wideners-v1 1.0.0+bd8a4a1860 via fabric
- fabricloader 0.13.3
- fabricshieldlib 1.5.3-1.18
- fake-player-api 0.3.0 via the_bumblezone
- farmersdelight 1.18.2-0.2.1
- feature_nbt_deadlock_be_gone 2.0.0+1.18.2-rc1
- fiber 0.23.0-2 via patchouli
- flesh2leather 1.0.3+1.18.2
- forgeconfigapiport 3.2.0
- geckolib3 3.0.35
- goblintraders 1.5.1
- goosik-config 0.2.0 via winterly
- guardiansgalore 1.18.2-3.0
- icarus 1.10
- incantationem 1.1.3+1.18.2
- indium 1.0.2+mc1.18.2
- ingredient-extension-api 2.0.5
- inventorysorter 1.8.6-1.18
- io_leangen_geantyref_geantyref 1.3.11 via croptopia
- iris 1.2.2-build.32
- java 17
- kyrptconfig 1.4.2-1.18 via inventorysorter
- libblockattributes 0.10.2
- libblockattributes_core 0.10.2 via libblockattributes
- libblockattributes_fluids 0.10.2 via libblockattributes
- libblockattributes_items 0.10.2 via libblockattributes
- litematica 0.11.1
- logical_zoom 0.0.14
- lovely_snails 1.0.4+1.18
- maelstrom_library 1.2.4-1.18.2 via bosses_of_mass_destruction
- magna 1.7.0-1.18-pre1 via modern_industrialization
- malilib 0.12.1
- matrix 1.0.0 via dimdoors
- maybe-data 1.1.0-1.18.2 via vanilla-hammers
- mcda 2.0.6
- mcdw 4.2.5
- mcwlights 1.0.3
- minecraft 1.18.2
- mm 2.3 via fabricshieldlib
- modern_industrialization 1.1.0-alpha.01
- modmenu 3.1.0
- more-axolotls 1.0.2
- morevillagers-fabric 3.2.0-SNAPSHOT
- mousetweaks 2.22
- multipart_entities 1.1.5-1.18.2 via bosses_of_mass_destruction
- mythicmounts 1.18.2-7.0
- ninjaphenix_container_lib 1.3.0
- omega-config 1.2.3-1.18.1 via fabric-furnaces
- org_anarres_jcpp 1.4.14 via iris
- org_jetbrains_kotlin_kotlin-reflect 1.6.10 via fabric-language-kotlin
- org_jetbrains_kotlin_kotlin-stdlib 1.6.10 via fabric-language-kotlin
- org_jetbrains_kotlin_kotlin-stdlib-jdk7 1.6.10 via fabric-language-kotlin
- org_jetbrains_kotlin_kotlin-stdlib-jdk8 1.6.10 via fabric-language-kotlin
- org_jetbrains_kotlinx_kotlinx-coroutines-core-jvm 1.5.2 via fabric-language-kotlin
- org_jetbrains_kotlinx_kotlinx-coroutines-jdk8 1.5.2 via fabric-language-kotlin
- org_jetbrains_kotlinx_kotlinx-serialization-cbor-jvm 1.3.1 via fabric-language-kotlin
- org_jetbrains_kotlinx_kotlinx-serialization-core-jvm 1.3.1 via fabric-language-kotlin
- org_jetbrains_kotlinx_kotlinx-serialization-json-jvm 1.3.1 via fabric-language-kotlin
- org_jgrapht_jgrapht-core 1.1.0 via dimdoors
- org_joml_joml 1.10.2 via sodium
- org_spongepowered_configurate-core 4.1.2 via croptopia
- org_spongepowered_configurate-hocon 4.1.2 via croptopia
- owo 0.6.0+1.18
- patchouli 1.18.2-66-FABRIC
- pigpen 8.0.1
- playerabilitylib 1.5.0 via modern_industrialization
- plushies 1.2
- puzzleslib 3.3.1
- quarryplus 18.2.517
- reach-entity-attributes 2.1.1 via campanion
- rightclickharvest 1.5.1
- roughlyenoughitems 8.0.442
- runelic 11.0.1
- seedfix 1.0.1
- sodium 0.4.1+build.15
- spectrum 1.3.1-1.18.2-midgame16-trinkets-brewing
- static-content 1.0.2-1.16.2 via vanilla-hammers
- staticdata 1.1.2 via static-content
- step-height-entity-attribute 1.0.0 via artifacts
- team_reborn_energy 2.2.0 via modern_industrialization
- the_bumblezone 5.0.8+1.18.2
- things 0.2.16+1.18
- thonkutil 2.12.0+1.18
- thonkutil-base 1.12.0+93f5607360 via thonkutil
- thonkutil-capes-v1 1.3.1+974d16dd60 via thonkutil
- thonkutil-coords-v1 1.0.18+4c66479160 via thonkutil
- thonkutil-customization-v1 1.0.13+4c66479160 via thonkutil
- thonkutil-legacy 1.0.19+aa74e18060 via thonkutil
- thonkutil-modchecker-v1 1.0.11+4c66479160 via thonkutil
- thonkutil-potions-v0 1.4.0+6d0d59d760 via thonkutil
- thonkutil-titlescreen-v1 1.1.8+4c66479160 via thonkutil
- thonkutil-trades-v1 1.1.19+4c66479160 via thonkutil
- trinketofundying 2.0.1-1.18
- trinkets 3.3.0
- vanilla-hammers 3.3.0-1.18.2
- vanilla_degus 1.3.0
- vanillaexcavators 1.1.0
- visualworkbench 3.3.0
- wildlife 1.18.2-1.0
- windchimes 1.2.0
- winterly 0.5.2
- wthit 4.8.0
- xaerominimap 22.4.0
- xaeroworldmap 1.20.5
- xp_storage 1.4.3+1.18

Kluzzio · Answer 1 · 2022-05-24T23:16:54.000Z

Our bag of souls and souldancer experience is incompatible with clumps. This is because clumps bypasses the Minecraft experience code as you might expect. We will not be making an exception for this.

jaredlll08 · Answer 2 · 2022-07-19T22:31:00.000Z

If I understand how you use your mixin correctly, this should be able to replace it if Clumps is present

1.18: jaredlll08/Clumps@0f6b7c4
1.19: jaredlll08/Clumps@a4169bd

        ClumpsEvents.VALUE_EVENT.register(event -> {
            event.setValue(9000000);
            return null;
        });

Give it a go and let me know if you need anything else

jaredlll08 · Answer 3 · 2022-07-10T18:45:52.000Z

Clumps author here, I only got told about this issue today.

If you would like, I can post an event that would let you change value over here:
https://github.com/jaredlll08/Clumps/blob/8350f5bc4c43713a002202f460c79cd14b2969b4/Common/src/main/java/com/blamejared/clumps/mixin/MixinExperienceOrb.java#L84

You could then use a mixin config to disable your mixin if Clumps is installed (or leave it, it should never run anyway) and use the event instead?

Just let me know if you would use the event and I can add it.

chronosacaria · Answer 4 · 2022-07-11T12:33:57.000Z

Hey @jaredlll08! We're all on holiday right now, but will be back next week. We'll talk it over and see if the event is something that we would use and then get back to you. Thank you, so much, for reaching out and offering to do that

chronosacaria · Answer 5 · 2022-07-18T14:26:44.000Z

Hey @jaredlll08! We're finally back from holiday! We would, absolutely, be interested in using an event from Clumps if you'd be willing to set something like that up so that we have compatibility. :)

Kluzzio · Answer 6 · 2022-07-26T14:32:11.000Z

Would you be able to pass in the player as a parameter in your call to fire the event? We have some logic that requires that we have the player. We only need the amount of experience (which you already provided) and the player. So if you can do that, or point us to a way that we can get the player without you needing to do that, that'd be great! If there is a way to get the player already on our side for the listener, forgive our stupid.
Thanks so much @jaredlll08 !

jaredlll08 · Answer 7 · 2022-07-26T16:47:18.000Z

It completely slipped my mind to give the player 😅

1.18: jaredlll08/Clumps@ec51b36
1.19: jaredlll08/Clumps@f328b12

Let me know if there is anything else you need

Kluzzio · Answer 8 · 2022-07-27T14:22:24.000Z

All done, and will be in next release. Thanks Jared!

jaredlll08 · Answer 9 · 2022-07-27T16:42:40.000Z

Looks good, just a heads up, Clumps is published to https://maven.blamejared.com
https://maven.blamejared.com/com/blamejared/clumps/Clumps-fabric-1.19/

No need to use curse maven

chronosacaria · Answer 10 · 2022-07-28T00:58:19.000Z

Ohh okay. That's good to know. It worked out, though, since I got to teach Kluzzio about how to use CurseMaven. We'll make it a point to update it, though since it makes a lot more sense to use your maven

Share to