MC Dungeons Armors

MC Dungeons Armors

11M Downloads

[Feature Request]: Apply the GlowSquid status "WaterBreathing" even while on land

FSKiller opened this issue ยท 2 comments

commented

Is your feature request related to a problem? Please describe.

I'm playing with a modpack called Medieval Minecraft, this modpack contains this mod and the origins mod that allows the user to choose a merling race. This race lives underwater and cannot breathe outside of it, BUT all the effects that apply to a normal player like Respiration III and Water Breathing from potions allow the merling to walk on land and breathe temporarily.

Describe the solution you'd like

I would like it if the set for GlowSquid armor also applied the Status even if the player is on land, this would allow the merling race described above to breathe normally outside of the water. I don't think it's very unbalanced since we would need all the parts of the armor just to be on land or in the Nether, this of course would impair the ability to use powerful armors and would force the player to always use the GlowSquid armor if they want to breathe on land.

Additional context

The needed changes would be to check for a config option so that players can set it themselves or just apply the effect anyways.
The code in question is in ArmorEffects.java:

if (playerEntity.isSubmergedInWater()) {
                playerEntity.addStatusEffect(new StatusEffectInstance(StatusEffects.WATER_BREATHING, 42, 0,
                        false, false));
            }

EDIT: I tested this change by removing the "if check" for submerged and i could breathe normally with the Merling Race :D

commented

Oh, that's interesting. I didn't realise that. I'll talk to Kluzzio about seeing what we can do about something like this

commented

Thank you for your consideration :D