[Bug Report]: Crafting weapons doesn't seem to give them enchantments
Martmists-GH opened this issue · 9 comments
Describe the bug; What happened?
Expected Behavior
The enchantment is on the weapon by default upon crafting
Mod Version
9.0.4
Minecraft Launcher
MultiMC
Operating System
Linux
Modpack
Custom, Fabric 1.20.1
Additional context
Mod list
- 3d-Skin-Layers
- AE2 EMI Crafting Integration
- AE2WTLib
- Ad Astra
- Ad Astra: Giselle Addon
- Additional Lanterns
- Adorn
- Akashic Tome Of Tools Fabric
- Alloy Forgery
- AlmostUnified
- AmbientSounds
- AppleSkin
- Applied Energistics 2
- Architectury
- Areas
- Armor Poser
- Artifacts
- Athena
- AttributeFix
- Augmented Reborn
- Auth Me
- AzureLib Armor
- BCLib
- Bad Wither No Cookie Reloaded
- BadOptimizations
- Balm
- Better Advancements
- Better Archeology
- Better Beds
- Better End
- Better End Delight
- Better Nether
- Better Ping Display
- Better Statistics Screen
- Better Third Person
- BetterF3
- BetterNether Delight
- BiomesOPlenty
- Block Runner
- Blockus
- Blur (Fabric)
- Bookshelf
- Bosses of Mass Destruction (Beta)
- Botania
- Botarium
- BounceStyles
- Bountiful
- Builtin Servers
- CC: Tweaked
- CICADA
- CTOV - BYG Compat
- CTOV - Chef's delight Compat
- CTOV - Croptopia compat
- CTOV - Friends and Foes Compat
- CTOV - Gazebo compat
- CTOV - More villagers compat
- CTOV - Paladins & Priests compat
- CTOV - Villagers Plus Compat
- CTOV - Wizards Compat
- Cardinal Components API
- Charm of Undying
- Chat Heads
- Chefs Delight
- Chipped
- Chunky
- Cinderscapes
- Cloth Config v11
- Clumps
- Collective
- Continuity
- Controlling For Fabric
- CorgiLib
- CraftPresence
- Crafting Tweaks
- Crate Delight
- Crawl
- CreativeCore
- Croptopia
- Dark Loading Screen
- Debugify
- Decorative Blocks
- Distant Horizons
- Diversity
- Do a Barrel Roll
- Dramatic Doors
- Duckling
- Dungeons and Taverns
- Dungeons and Taverns Ancient City Overhaul
- Dungeons and Taverns Pillager Outpost Rework
- Dungeons and Taverns Stronghold Rework
- Dungeons and Taverns Swamp Hut Rework
- Dungeons+
- EMI
- EMI Enchanting
- EMI Loot
- EMI Ores
- EMI Trades
- EMIffect
- Easy NPC
- Echo Chest
- Elytra Slot
- EmoteTweaks
- Emotecraft
- End's Delight
- Ender Dragon Fight Remastered
- Enhanced Block Entities
- Entity Model Features
- Entity Texture Features
- EntityCulling
- EpheroLib
- Etcetera
- Euphoria Patcher
- Expanded Delight
- Explorer's Compass
- Extra Mod Integrations
- Fabric API
- Fabric Language Kotlin
- Fabric Seasons
- Fabric Seasons: Extras
- Fabric Seasons: Terraformers Compat
- Fabric Seasons: Terralith Compat
- Falling Leaves
- FallingTree
- FancyDelight
- Farmer's Cutting: BetterNether
- Farmer's Cutting: Biomes O' Plenty
- Farmer's Cutting: Cinderscapes
- Farmer's Cutting: Oh The Biomes We've Gone
- Farmer's Cutting: Terrestria
- Farmer's Delight
- FerriteCore
- Forge Config API Port
- Freecam (Modrinth Edition)
- Friends & Foes
- Fusion
- Fzzy Config
- Gamma Utils
- GeckoLib 4
- Geophilic
- GlitchCore
- Global Packs
- Handcrafted
- Head In The Clouds
- Hephaestus
- Hex Casting
- Immersive Paintings
- Immersive Thunder
- Incendium
- Indium
- Industrialization de Astra
- Inline
- Inventory Profiles Next
- Iris
- Jade
- Jade Addons
- Jewelry (RPG Series)
- JumpOverFences
- Just Enough Breeding
- Kambrik
- Katters Structures
- Krypton
- KubeJS
- LambDynamicLights
- Lavender
- Litematica
- Lithium
- Lootr
- Luki's Crazy Chambers
- Luki's Grand Capitals
- MC Dungeons Armors
- MC Dungeons Weapons
- MaLiLib
- Macaw's Bridges
- Macaw's Doors
- Macaw's Fences and Walls
- Macaw's Furniture
- Macaw's Holidays
- Macaw's Lights and Lamps
- Macaw's Paintings
- Macaw's Paths and Pavings
- Macaw's Roofs
- Macaw's Stairs and Balconies
- Macaw's Trapdoors
- Macaw's Windows
- Magnum Torch
- Majrusz Library
- Majrusz's Accessories
- Malum
- Medieval Buildings
- MidnightLib
- Mod Loading Screen
- Mod Menu
- Model Gap Fix
- Moonlight
- More Culling
- More Delight
- More Mob Variants
- More Villagers
- Mouse Tweaks
- Mythic Metals
- Mythic Metals Decorations
- Mythic Mounts
- Naturalist
- Nature's Compass
- No Chat Reports
- Nullscape
- Numismatic Overhaul
- Ocean's Delight
- Oh The Biomes We've Gone
- Oh The Trees You'll Grow
- Open Parties and Claims
- Overflowing Bars
- PAUCAL
- Paladins & Priests (RPG Series)
- Patchouli
- Pehkui
- Peripheralium
- Philip`s Ruins
- Ping Wheel
- Placeholder API
- Player Animator
- Plethora
- Polymorph
- Polymorphic Energistics
- Porting Lib
- Presence Footsteps
- Puzzles Lib
- Random Village Names
- RangedWeaponAPI
- Reacharound
- Reborn Core
- Rechiseled
- Reese's Sodium Options
- Remove Terralith Intro Message
- Replay Mod
- Resourceful Lib
- Resourcefulconfig
- Rhino
- Rogues & Warriors (RPG Series)
- Runes
- Rustic Delight
- Searchables
- SeasonHUD
- Seed Delight Fabric
- Shield API
- Show Me Your Skin!
- Shulker Box Tooltip
- Simple Voice Chat
- SimpleHats
- Sodium
- Sodium Extra
- Sodium Shadowy Path Blocks
- Sound Physics Remastered
- Spell Engine
- Spell Power Attribute
- Spyglass Astronomy
- Staff of Building
- Starter Kit
- Status
- Stoneworks
- Storage Delight
- SuperMartijn642's Config Lib
- SuperMartijn642's Core Lib
- TCD Commons API
- TVSMP Addons
- Tech Reborn
- Tectonic
- Telepistons
- TerraBlender
- Terralith
- Terrestria
- Thigh highs etc
- Things
- Tidal Towns
- ToolTip Fix
- Trash Cans
- TrashSlot
- Traveler's Backpack
- Traverse
- Trinkets
- UniLib
- Universal Sawmill
- Unlimited Peripheral Works
- Vegan Delight
- Vein Mining
- Very Many Players
- Villagers Plus
- Visuality
- Waystones
- When Dungeons Arise
- Wizards (RPG Series)
- WorldEdit
- WorldEditCUI
- XLPackets
- XP Storage
- XP Storage - Trinkets
- Xaero's Minimap
- Xaero's World Map
- YOSBR
- YUNG's API
- YetAnotherConfigLib
- You're in Grave Danger
- Yuushya
- Zoomify
- autofish
- clickadv mod
- cupboard
- fabric-medievalend-1.0.1
- idwtialsimmoedm
- libIPN
- lodestone-1.20.1-1.6.2.3f-fabric
- oωo
The issue seems to have occurred in a Hephaestus Crafting Station; regular Crafting Tables work fine
@Martmists-GH Ohhhh okay. That makes sense since they have different handlers. I should be able to add support for this in 1.21. Thanks for the heads up!
I will say that anything that messes with the CraftingScreenHandler could, potentially, cause this issue. Could you upload your latest.log, please, so I can see which mod it is? It should be in the log. If you'd rather DM it to me, feel free to DM it to me on Discord or post it via the Timefall Development Discord Server (https://discord.gg/HGQUUSrwt3)
While the image only shows EMI, the result is the same when actually crafting the weapon.
@Martmists-GH That's odd. Usually people have the other issue where they cannot find them enchanted in chests; but that is on Forge. Have you changed the config for MCDW at all?
I haven't really bothered since most mods I'm interested in dropped support for Fabric after 1.20.1, but I can't imagine the difference being too great comparing it to every other major update I've been through.
@Martmists-GH It is unlikely as we've already started the porting process for 1.21 and, as a dev yourself, in sure you've seen the madness that has been 1.21