Incompatibility with Clumps
BugmanBugman opened this issue · 7 comments
1.16.4
It just happened with MCMT and Clumps
Also I don’t see the point of a debug log since it was just filled with the same error as the one I posted
This is an issue with clumps not being concurrent capible; I can look into adding a better solution but for now the best solution would be to disable world multithreading
Run /mcmt config world
and that should fix it
Can you be more specific please.
For example in what time it happened (are you clicked something or what).
With what mods this happened???
debug.log should be useful too.
In what version?
etc.
I've gotten a few reports about this.
I have no interest in changing how clumps works, changing it would on my side would be like nerfing my own code to fix an issue that I'm sure tons of other mods are going to run into.
Also just by the way, in your readme:
TO MODDERS: This mod logs at warn level to the log saying it is installed every ~3 minutes and that the logs are invalid. It should be really obvious.
I have only ever seen crash reports, and none of those make it obvious that this mod is installed.
Just a heads up, since I really don't like sifting through crash reports with no apparent real cause, I am going to be marking this mod as incompatible on CurseForge.
No problem; I'll look into an auto toggle for the onWorldPostTick hook (i.e. if exception occurs serialise) since it is likely there would be other compatibility things that may be less easy to track down.
And sorry again for causing you undue headache with bug reports, that was what I'd been trying to avoid
I've fixed this now, you can restore compatibility by setting disableWorldPostTick = true
in the config file, which re-serialises the onWorldPostTick event
@jaredlll08 should I add a note of "how to change the config to make it compatible" and then you just leave the incompat flag set? IDK exactly how this works. Also sorry about this having been a pain, and I think I've properly hooked into the crash reports as of the latest release. (And sorry for the delayed response Uni + Mental health has been delaying this project)
And sorry for the delayed response Uni + Mental health has been delaying this project
You should never apologise for prioritising uni / health over mods.
I do think you should make a note about the config stuff though, since I'm sure Clumps can't be the only mod that this would affect.
As for the incompatability flag, I'll remove it for the time being (jaredlll08/Clumps@1b2ea8c), if I start getting reports about it I will unfortunately have to add it back, so lets see how it goes.