MedievalWeapons

MedievalWeapons

3M Downloads

Crash when rendering a player that is using a medieval weapon

UltimateCoffee opened this issue ยท 12 comments

commented

Client crashes anytime it tries to render a player with a medieval weapon. Even if I hit F5 to view myself while holding one.

https://pastebin.com/0V0912mM

commented

All the unique weapons are actually what's causing the issue. longsword, dagger, recurve bow, and long bow work fine, all other weapons cause the client rendering them to crash (3rd person view only).

WORKS:
Longsword, Dagger, Battleaxe, Francisca(throwing axe), Recurve Bow, Long Bow

DOESN'T WORK:
Healing Staff, Mace, Waraxe, Javeline, Lance

commented

Looks like it is incompatible with the mod called BannerCapeFeatureRenderer

commented

I appreciate the response.
I just tested on a new server, with only MedievalWeapons and the mod MoreBannerFeatures, which has the BannerCapeFeatureRenderer. With only these mods, everything works fine.
Additionally, I got the crash again, and a new crash report. This one doesn't mention the BannerCapeFeatureRenderer.
Can you advise please?

https://pastebin.com/HPws45eM

commented

Found the issue. There is an incompatibility with the Pehkui mod.
Is it possible for you to fix this?
If Pehkui and MedievalWeapons are installed, when you see a 3rd person model in the world holding one of the problem weapons: Healing Staff, Mace, Waraxe, Javeline, Lance: the client crashes.

Note: Found that the items that crash the game are the ones with defined renderers...

image

commented

do you use the latest mod version?

commented

Yes,
MedievalWeapons 1.1.6
Fabric API 0.39.2
Fabric 0.11.6
Pehkui 2.3.0

commented

mh, it should have been fixed with this #31
Wondering why it doesn't work

commented

Not sure. Just downloaded the latest of this mod, its dependencies, and pehkui. Tested using only these newly downloaded mods on a clean minecraft fabric install and got the same crash.

https://pastebin.com/X5Rf8tht

commented

It looks like this commit was made on Aug 22, 2021
The latest release of the mod was on July 19, 2021

Is it possible this code change isn't in the released version of the mod, that I am downloading?

commented

Rebuilt the mod from github.
The rebuilt mod is working.

commented

oh xD than I forgot to release an update

commented

Thanks for the help!